Remove blacklist sensitive language#977
Remove blacklist sensitive language#977lzchen merged 5 commits intocensus-instrumentation:masterfrom
Conversation
|
|
||
| BLACKLIST_PATHS = 'BLACKLIST_PATHS' | ||
| BLACKLIST_HOSTNAMES = 'BLACKLIST_HOSTNAMES' | ||
| EXCLUDELIST_PATHS = 'EXCLUDELIST_PATHS' |
There was a problem hiding this comment.
If I understand correctly, this is a breaking change?
@aabmass please make sure that this is okay / we bump major release version and mention this in the changelog if we decide to merge this change.
There was a problem hiding this comment.
The packages that are breaking will be flask, django and pyramid. Giving the current versioning strategy (we update the packages that change with the core Opencensus package), which is currently at v0.7.10, what should we update this to?
There was a problem hiding this comment.
If we bump the major version to v1.7.0, it wouldn't really make sense in the future if other packages change and we match them to a new major version. Should we not have packages be updated in lockstep?
There was a problem hiding this comment.
For semver major versions < 1, minor version bumps are not compatible: https://semver.org/#spec-item-4. So from semver perspective, we don't need to do a major version bump.
If users are using the "compatible release" specifier (or stricter) like opencensus-foo ~= 0.7.0, it will not automatically start installing the next minor version.
aabmass
left a comment
There was a problem hiding this comment.
@nilebox I agree this isn't great for users, but I think from a versioning point of view it's ok. I remember there being some OpenCensus breaking changes guidelines where you should give 30 day deprecation notice -- do you remember if those were project-wide or just for one specific repo?
I think it was documented in some repo, but couldn't find it. |
|
Think the breaking change could've been communicated in the changelog. |
|
@tpyo |
|
Hello,
But the software is built for users, not versioning, isn't it? |
We will be using "Exclude list" instead to refer to endpoints that are not going to be traced.