Skip to content

Fixed BarChart's children have no keys#446

Merged
Hermanya merged 2 commits into
chart-kit:masterfrom
wuweijian1997:master
Dec 8, 2020
Merged

Fixed BarChart's children have no keys#446
Hermanya merged 2 commits into
chart-kit:masterfrom
wuweijian1997:master

Conversation

@wuweijian1997

Copy link
Copy Markdown
Contributor

Fixed BarChart Warning: Each child in a list should have a unique 'key' prop

@Hermanya

Hermanya commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

looks like there already was a pr with this change

@Hermanya Hermanya closed this Dec 6, 2020
@wuweijian1997

Copy link
Copy Markdown
Contributor Author

I don't think it's a good solution.
image

@Hermanya Hermanya reopened this Dec 7, 2020
@Hermanya

Hermanya commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

If you rebase your PR, I'll accept it

@wuweijian1997

Copy link
Copy Markdown
Contributor Author

Is this ok?

@Hermanya Hermanya merged commit 2611a25 into chart-kit:master Dec 8, 2020
@Hermanya

Hermanya commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

thank you, this is now available in v6.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants