Skip to content

Fixed BarChart's children have no keys #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hermanya merged 2 commits into from
Dec 8, 2020
+4 −1
Merged

Fixed BarChart's children have no keys #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffe6ca4
fixed BarChart Warning: Each child in a list should have a unique 'ke…
Dec 3, 2020
da6352a
Merge branch 'master' into master
wuweijian1997 Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BarChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class BarChart extends AbstractChart<BarChartProps, BarChartState> {
flatColor: boolean;
}) => {
return data.map((dataset, index) => (
<Defs key={Math.random()}>
<Defs key={dataset.key ?? index}>
{dataset.colors?.map((color, colorIndex) => {
const highOpacityColor = color(1.0);
const lowOpacityColor = color(0.1);
Expand Down
3 changes: 3 additions & 0 deletions src/HelperTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ export interface Dataset {

/** Override of LineChart's withScrollableDot property just for this dataset */
withScrollableDot?: boolean;

/** Unique key **/
key?: string | number;
}

export interface ChartData {
Expand Down