fix(clerk-js): Remove session cookie when signing out and `onBeforeSetActive` by octoper · Pull Request #3371 · clerk/javascript

octoper · 2024-05-13T09:37:18Z

Description

Problem:

Right now when signing out on Next.js with app router, there is a chance that you will get an error as we are clearing the app router cache before removing the session cookie.

Solution:

The solution is to move the removal of the session cookie before clearing the app router cache.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-05-13T09:37:22Z

🦋 Changeset detected

Latest commit: c469a32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

octoper · 2024-05-13T09:37:28Z

!snapshot

clerk-cookie · 2024-05-13T09:42:05Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/chrome-extension	1.0.9-snapshot.v40b4e54
@clerk/clerk-js	5.2.5-snapshot.v40b4e54
@clerk/clerk-expo	1.1.1-snapshot.v40b4e54
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.0-snapshot.v40b4e54

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.9-snapshot.v40b4e54 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.2.5-snapshot.v40b4e54 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.1-snapshot.v40b4e54 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.0-snapshot.v40b4e54 --save-exact

octoper · 2024-05-13T10:04:04Z

!snapshot

clerk-cookie · 2024-05-13T10:07:39Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/chrome-extension	1.0.9-snapshot.v3595faf
@clerk/clerk-js	5.2.5-snapshot.v3595faf
@clerk/clerk-expo	1.1.1-snapshot.v3595faf
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.0-snapshot.v3595faf

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.9-snapshot.v3595faf --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.2.5-snapshot.v3595faf --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.1-snapshot.v3595faf --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.0-snapshot.v3595faf --save-exact

octoper · 2024-05-13T10:11:36Z

!snapshot

clerk-cookie · 2024-05-13T10:15:41Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/chrome-extension	1.0.9-snapshot.vb1a12ac
@clerk/clerk-js	5.2.5-snapshot.vb1a12ac
@clerk/clerk-expo	1.1.1-snapshot.vb1a12ac
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.0-snapshot.vb1a12ac
@clerk/nextjs	5.0.9-snapshot.vb1a12ac

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.9-snapshot.vb1a12ac --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.2.5-snapshot.vb1a12ac --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.1-snapshot.vb1a12ac --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.0-snapshot.vb1a12ac --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.9-snapshot.vb1a12ac --save-exact

octoper · 2024-05-14T20:29:59Z

!snapshot

clerk-cookie · 2024-05-14T20:34:57Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/chrome-extension	1.0.9-snapshot.v5ac0a48
@clerk/clerk-js	5.2.5-snapshot.v5ac0a48
@clerk/clerk-expo	1.1.1-snapshot.v5ac0a48
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.0-snapshot.v5ac0a48
@clerk/nextjs	5.0.9-snapshot.v5ac0a48

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.9-snapshot.v5ac0a48 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.2.5-snapshot.v5ac0a48 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.1-snapshot.v5ac0a48 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.0-snapshot.v5ac0a48 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.9-snapshot.v5ac0a48 --save-exact

octoper · 2024-05-15T11:48:45Z

!snapshot

clerk-cookie · 2024-05-15T11:52:31Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.1.5-snapshot.v58e76d6
@clerk/chrome-extension	1.0.10-snapshot.v58e76d6
@clerk/clerk-js	5.3.1-snapshot.v58e76d6
@clerk/elements	0.4.2-snapshot.v58e76d6
@clerk/clerk-expo	1.1.2-snapshot.v58e76d6
@clerk/express	0.0.8-snapshot.v58e76d6
@clerk/fastify	1.0.7-snapshot.v58e76d6
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/nextjs	5.0.10-snapshot.v58e76d6
@clerk/clerk-react	5.0.6-snapshot.v58e76d6
@clerk/remix	4.0.8-snapshot.v58e76d6
@clerk/clerk-sdk-node	5.0.7-snapshot.v58e76d6
@clerk/shared	2.1.1-snapshot.v58e76d6
@clerk/testing	1.0.5-snapshot.v58e76d6

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.1.5-snapshot.v58e76d6 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.10-snapshot.v58e76d6 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.3.1-snapshot.v58e76d6 --save-exact

@clerk/elements

npm i @clerk/elements@0.4.2-snapshot.v58e76d6 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.2-snapshot.v58e76d6 --save-exact

@clerk/express

npm i @clerk/express@0.0.8-snapshot.v58e76d6 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.7-snapshot.v58e76d6 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.10-snapshot.v58e76d6 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.0.6-snapshot.v58e76d6 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.8-snapshot.v58e76d6 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.7-snapshot.v58e76d6 --save-exact

@clerk/shared

npm i @clerk/shared@2.1.1-snapshot.v58e76d6 --save-exact

@clerk/testing

npm i @clerk/testing@1.0.5-snapshot.v58e76d6 --save-exact

octoper · 2024-05-15T13:23:16Z

!snapshot

clerk-cookie · 2024-05-15T13:25:35Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/nextjs	5.0.11-snapshot.vcf12ff3

Tip: Use the snippet copy button below to quickly install the required packages.
gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.0.11-snapshot.vcf12ff3 --save-exact

nikosdouvlis

Nice one @octoper 👏🏻
I will test a little bit more, add a few unit tests and I'll merge right after

brkalow

👏

… sign out

…en signing out

clerk-cookie added the nextjs label May 13, 2024

clerk-cookie added clerk-js and removed nextjs labels May 14, 2024

octoper force-pushed the vaggelis.fix/auth-state-not-updated-after-sign-out branch from 5ac0a48 to 3019c67 Compare May 15, 2024 10:18

octoper force-pushed the vaggelis.fix/auth-state-not-updated-after-sign-out branch from 5ac9520 to cf12ff3 Compare May 15, 2024 13:23

octoper changed the title ~~fix(nextjs): Auth state not updated correctly after sign out for App router~~ fix(clerk-js): Remove session cookie when signing out and onBeforeSetActive May 15, 2024

octoper marked this pull request as ready for review May 15, 2024 13:33

panteliselef assigned octoper May 15, 2024

octoper requested review from dimkl, nikosdouvlis and panteliselef May 15, 2024 13:39

nikosdouvlis approved these changes May 15, 2024

View reviewed changes

brkalow approved these changes May 15, 2024

View reviewed changes

octoper added 4 commits May 16, 2024 02:05

fix(nextjs): Fix auth state not updated correctly in app router after…

ff2c712

… sign out

chore(repo): Add Changeset

71a864e

fix(clerk-js,nextjs): Remove cookie before calling beforeSetActive wh…

c5aa750

…en signing out

fix(clerk-js): Use TokenUpdate event to remove the session token

28d01fd

octoper and others added 3 commits May 16, 2024 02:05

chore(clerk-js): Remove uneeded events.TokenUpdate dispatch

0feec52

chore(clerk-js): Update changeset

c444488

chore(clerk-js): Add test

c469a32

nikosdouvlis force-pushed the vaggelis.fix/auth-state-not-updated-after-sign-out branch from b4beda6 to c469a32 Compare May 16, 2024 01:17

nikosdouvlis merged commit 1fdd436 into main May 16, 2024

nikosdouvlis deleted the vaggelis.fix/auth-state-not-updated-after-sign-out branch May 16, 2024 02:04

clerk-cookie mentioned this pull request May 16, 2024

Version Packages #3390

Merged

brkalow mentioned this pull request Aug 22, 2024

fix(clerk-js): Keep the session cookie while cache is being invalidated #4001

Merged

9 tasks

Uh oh!

Conversation

octoper commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

octoper commented May 13, 2024

Uh oh!

clerk-cookie commented May 13, 2024

Uh oh!

octoper commented May 13, 2024

Uh oh!

clerk-cookie commented May 13, 2024

Uh oh!

octoper commented May 13, 2024

Uh oh!

clerk-cookie commented May 13, 2024

Uh oh!

octoper commented May 14, 2024

Uh oh!

clerk-cookie commented May 14, 2024

Uh oh!

octoper commented May 15, 2024

Uh oh!

clerk-cookie commented May 15, 2024

Uh oh!

octoper commented May 15, 2024

Uh oh!

clerk-cookie commented May 15, 2024

Uh oh!

nikosdouvlis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brkalow left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

octoper commented May 13, 2024 •

edited

Loading

changeset-bot Bot commented May 13, 2024 •

edited

Loading

nikosdouvlis left a comment •

edited

Loading