fix(clerk-js): Keep the session cookie while cache is being invalidated - #4001
Merged
nikosdouvlis merged 1 commit intoAug 28, 2024
Conversation
🦋 Changeset detectedLatest commit: 27d9cb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
force-pushed
the
nikos/sdki-611-404-errors-on-sign-out-while-user-is-on-a-protected-route
branch
from
August 22, 2024 16:03
c033dc9 to
a0804a9
Compare
nikosdouvlis
marked this pull request as ready for review
August 22, 2024 19:33
Member
|
@nikosdouvlis @octoper does this reintroduce the bug that was fixed by #3371? We explicitly made a change to ensure the session cookie was cleared before clearing the cache on sign out. |
nikosdouvlis
marked this pull request as draft
August 22, 2024 21:16
nikosdouvlis
marked this pull request as ready for review
August 27, 2024 08:23
Otherwise, in Nextjs apps the invalidate cache server action will result in a 404 if current route is being protected by auth().protect()
nikosdouvlis
force-pushed
the
nikos/sdki-611-404-errors-on-sign-out-while-user-is-on-a-protected-route
branch
from
August 27, 2024 10:47
f54a77f to
27d9cb6
Compare
nikosdouvlis
deleted the
nikos/sdki-611-404-errors-on-sign-out-while-user-is-on-a-protected-route
branch
August 28, 2024 08:31
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, in Nextjs apps the invalidate cache server action will result in a 404 if current route is being protected by auth().protect()
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change