Skip to content

fix(clerk-js): Fix space encoding for query params - #4219

Closed
octoper wants to merge 1 commit into
mainfrom
vaggelis/sdki-674-query-string-implementation-does-not-match-qs-case-for
Closed

fix(clerk-js): Fix space encoding for query params#4219
octoper wants to merge 1 commit into
mainfrom
vaggelis/sdki-674-query-string-implementation-does-not-match-qs-case-for

Conversation

@octoper

@octoper octoper commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes space encoding for query params, to match the previous the implementation of qs library we previously had (removed in #3430).

Previously when we were using the qs library the spaces in the query param value where encoded with %20

But now that we are casting URLSearchParams instance to string replaces the spaces in values with + and this is breaking change

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@octoper octoper self-assigned this Sep 25, 2024
@changeset-bot

changeset-bot Bot commented Sep 25, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 05452a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
octoper force-pushed the vaggelis/sdki-674-query-string-implementation-does-not-match-qs-case-for branch from 997f8ce to 05452a3 Compare September 25, 2024 11:39

@anagstef anagstef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper

octoper commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.3.11-snapshot.v05452a3
@clerk/clerk-js 5.23.1-snapshot.v05452a3
@clerk/clerk-expo 2.2.17-snapshot.v05452a3

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.11-snapshot.v05452a3 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.23.1-snapshot.v05452a3 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.17-snapshot.v05452a3 --save-exact

@octoper

octoper commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot @clerk/clerk-react

@octoper

octoper commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

!snapshot react

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.3.11-react.v05452a3
@clerk/clerk-js 5.23.1-react.v05452a3
@clerk/clerk-expo 2.2.17-react.v05452a3

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.11-react.v05452a3 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.23.1-react.v05452a3 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.17-react.v05452a3 --save-exact

@octoper
octoper marked this pull request as draft September 25, 2024 13:36
@nikosdouvlis

Copy link
Copy Markdown
Member

Hey @octoper , is this good to go?

@octoper octoper closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants