fix(clerk-js): Fix space encoding for query params - #4219
Conversation
🦋 Changeset detectedLatest commit: 05452a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
997f8ce to
05452a3
Compare
|
!snapshot |
|
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.3.11-snapshot.v05452a3 --save-exact
npm i @clerk/clerk-js@5.23.1-snapshot.v05452a3 --save-exact
npm i @clerk/clerk-expo@2.2.17-snapshot.v05452a3 --save-exact |
|
!snapshot @clerk/clerk-react |
|
!snapshot react |
|
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@1.3.11-react.v05452a3 --save-exact
npm i @clerk/clerk-js@5.23.1-react.v05452a3 --save-exact
npm i @clerk/clerk-expo@2.2.17-react.v05452a3 --save-exact |
|
Hey @octoper , is this good to go? |
Description
This PR fixes space encoding for query params, to match the previous the implementation of
qslibrary we previously had (removed in #3430).Previously when we were using the
qslibrary the spaces in the query param value where encoded with%20But now that we are casting
URLSearchParamsinstance to string replaces the spaces in values with+and this is breaking changeChecklist
npm testruns as expected.npm run buildruns as expected.Type of change