Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-dots-trade.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/clerk-js": patch
---

Fix space encoding for query params
16 changes: 16 additions & 0 deletions packages/clerk-js/src/utils/__tests__/querystring.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ describe('getQueryParams(string)', () => {
const res = getQueryParams('?foo=42&foo=43&bar=1');
expect(res).toEqual({ foo: ['42', '43'], bar: '1' });
});

it('parses spaces and "+" characters correctly', () => {
expect(getQueryParams('test=foo%20bar')).toEqual({ test: 'foo bar' });
expect(getQueryParams('test=foo%2Bbar%20lab')).toEqual({ test: 'foo+bar lab' });

expect(getQueryParams('?foo=42%20hey&foo=43%20%2B&bar=1')).toEqual({ foo: ['42 hey', '43 +'], bar: '1' });
expect(getQueryParams('?foo=42%20hey&foo=43&bar=1')).toEqual({ foo: ['42 hey', '43'], bar: '1' });
});
});

describe('stringifyQueryParams(object)', () => {
Expand Down Expand Up @@ -69,6 +77,14 @@ describe('stringifyQueryParams(object)', () => {
expect(stringifyQueryParams({ test: false, boo: true })).toBe('test=false&boo=true');
});

it('handles spaces and "+" characters correctly', () => {
expect(stringifyQueryParams({ test: 'foo bar' })).toBe('test=foo%20bar');

expect(stringifyQueryParams({ test: 'foo+bar lab' })).toBe('test=foo%2Bbar%20lab');

expect(stringifyQueryParams({ test: ['foo+bar lab', 'new+'] })).toBe('test=foo%2Bbar%20lab&test=new%2B');
});

it('converts an object to querystring when key is camelCase', () => {
expect(stringifyQueryParams({ barFoo: '1' }, { keyEncoder: camelToSnake })).toBe('bar_foo=1');
expect(stringifyQueryParams({ unsafeMetadata: { bar: '1' } }, { keyEncoder: camelToSnake })).toBe(
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/src/utils/querystring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ export const stringifyQueryParams = (
}
});

return queryParams.toString();
return queryParams.toString().replace(/\+/g, '%20');
};