[workers] fix incorrect getCookie function in extract-cookie-value.md #2074
Closed
talismanium wants to merge 2 commits into
Closed
[workers] fix incorrect getCookie function in extract-cookie-value.md #2074talismanium wants to merge 2 commits into
talismanium wants to merge 2 commits into
Conversation
fix for correct cookie find. for example, if cookie values are aaaa=triple; aa=double; call getCookie(request, 'aa') will return first occurance of "aa=", which leads to wrong value of "triple" I fix searching phrase by leading space, and to all cookie string add leading space
VARsbyTOP
approved these changes
Aug 17, 2021
Contributor
|
Thanks for this! It spawned some discussion. While technically this is more correct, it's also a little bit weird & still brittle for a production setting. We decided to update this example to use a third-party package so that it's robust and ready-to-go (#2101). Updating this example to be production-ready would just mean copy-pasting library code as an example, which isn't very ideal. Thanks again~! |
lukeed
added a commit
that referenced
this pull request
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for correct cookie find. for example, if cookie values are aaaa=triple; aa=double;
call getCookie(request, 'aa') will return first occurance of "aa=", which leads to wrong value of "triple"
I fix searching phrase by leading space, and to all cookie string add leading space