Skip to content

chore: defer cookie parsing to external package;#2101

Merged
lukeed merged 1 commit into
productionfrom
example/cookie
Aug 18, 2021
Merged

chore: defer cookie parsing to external package;#2101
lukeed merged 1 commit into
productionfrom
example/cookie

Conversation

@lukeed

@lukeed lukeed commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

@signalnerve Since our examples are each in a single file right now, this <Aside> seemed like the best alternative since there's no way to include a package.json for this specific example. (We can do this in the rework, of course)

Unless you meant that I should include a snippet showing package.json contents, like this:

// package.json
{
  "dependencies": {
    "cookie": "0.4.1",
    "worktop": "0.7.1"
  }
}

Closes #2074

@lukeed
lukeed requested a review from a team August 18, 2021 16:48
@lukeed
lukeed requested a review from a team as a code owner August 18, 2021 16:48

@kristianfreeman kristianfreeman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with it like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants