DO NOT MERGE: revert: nimbus to live - #32182
Closed
MohamedH1998 wants to merge 1 commit into
Closed
Conversation
Contributor
Review
Fix in your agentFix the following review findings in PR #32182 (https://github.com/cloudflare/cloudflare-docs/pull/32182).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Code Review
### Warnings (2)
#### CR-c7a8c9f8108c · process.exit() overrides failed exit code
- **File:** `bin/post-pr-ci-failure-comment/index.ts` line 35
- **Issue:** The added `core.setFailed(...)` on line 35 is immediately followed by a no-argument `process.exit()` on line 36. `process.exit()` with no argument exits with code 0, which can cause the GitHub Action step to report success even though `core.setFailed()` sets the failure message and intended exit code.
- **Fix:** Remove `process.exit()` after `core.setFailed()` so the toolkit can set the proper non-zero exit code, or pass a non-zero code explicitly: `process.exit(1)`.
#### CR-b851c76505a7 · Collection glob excludes existing .mdx content
- **File:** `src/nimbus/content.config.ts` line 323
- **Issue:** The loader pattern was narrowed from `*.{md,mdx}` to `*.md`. The directory `src/content/compatibility-flags/` contains `nodejs-compat.mdx`, which has valid compatibility-flag frontmatter (`name: "Node.js compatibility"`) and will now be silently dropped from the collection.
- **Fix:** Restore `pattern: "*.{md,mdx}"` so the existing `.mdx` compatibility flag is included in the Nimbus build.
---
## Style Guide Review
### Warnings (1)
#### SG-734ad0616028 · Table introduction must be a complete sentence ending in a colon
- **File:** `src/content/changelog/waf/2026-07-21-waf-release.mdx` line 24
- **Issue:** HTML table starts with `<table style="width: 100%">` without any preceding introductory sentence.
- **Fix:** Add a complete sentence before the table ending in a colon, e.g. "This release includes the following rule changes:"
### Suggestions (3)
#### SG-f472c45946e9 · Use the Oxford comma for lists of three or more items
- **File:** `src/content/changelog/waf/2026-07-21-waf-release.mdx` line 9
- **Issue:** Lists three items joined with `and` without a serial comma: `Generic Rules - ... (RCE), Generic Rules - ... (Auth Bypass - 2) and Generic Rules - ... Disclosure`
- **Fix:** Add a comma before `and`: `Generic Rules - ... Disclosure.`
#### SG-d1f815015c79 · Passive voice
- **File:** `src/content/changelog/access/2026-07-20-http-private-apps-l7-auth.mdx` line 13
- **Issue:** Line contains "No configuration change is required" and "The Cloudflare One Client is still required"
- **Fix:** Rewrite in active voice, e.g., "You do not need to change the configuration. You still need the Cloudflare One Client to route traffic..."
#### SG-4d284bf0be2d · Passive voice
- **File:** `src/content/docs/cloudflare-one/access-controls/applications/non-http/self-hosted-private-app.mdx` line 92
- **Issue:** Line adds `session management is [handled in the Cloudflare One Client](#other-non-http-applications)`
- **Fix:** Rewrite in active voice, e.g. `the Cloudflare One Client handles session management`
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (2)
ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
Suggestions (3)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Nimbus Preview URL: https://nimbus-9886bddd.preview.developers.cloudflare.com |
Contributor
|
Preview URL: https://9886bddd.preview.developers.cloudflare.com |
diogoascarneiro
self-requested a review
July 20, 2026 20:27
kodster28
approved these changes
Jul 20, 2026
diogoascarneiro
approved these changes
Jul 20, 2026
MohamedH1998
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
asamborski,
ay-cf,
danielegm,
elithrar,
hsaxenaCF,
irvinebroque,
kennyj42,
korinne,
vs-mg and
vy-ton
as code owners
July 21, 2026 12:21
This reverts commit 6ef6c18.
MohamedH1998
force-pushed
the
revert/nimbus-to-live
branch
from
July 21, 2026 12:27
4beb418 to
9886bdd
Compare
MohamedH1998
requested review from
ahaywood,
colbywhite and
mvvmm
as code owners
July 21, 2026 12:27
MattieTK
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert nimbus to live (follow up ticket to this just incase things go wrong)
Screenshots (optional)
Documentation checklist