Skip to content

DO NOT MERGE: revert: nimbus to live - #32182

Closed
MohamedH1998 wants to merge 1 commit into
productionfrom
revert/nimbus-to-live
Closed

DO NOT MERGE: revert: nimbus to live#32182
MohamedH1998 wants to merge 1 commit into
productionfrom
revert/nimbus-to-live

Conversation

@MohamedH1998

Copy link
Copy Markdown
Contributor

Summary

Revert nimbus to live (follow up ticket to this just incase things go wrong)

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 3 warnings, 💡 3 suggestions found in commit 9886bdd.

Fix in your agent
Fix the following review findings in PR #32182 (https://github.com/cloudflare/cloudflare-docs/pull/32182).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.

---

## Code Review

### Warnings (2)

#### CR-c7a8c9f8108c · process.exit() overrides failed exit code
- **File:** `bin/post-pr-ci-failure-comment/index.ts` line 35
- **Issue:** The added `core.setFailed(...)` on line 35 is immediately followed by a no-argument `process.exit()` on line 36. `process.exit()` with no argument exits with code 0, which can cause the GitHub Action step to report success even though `core.setFailed()` sets the failure message and intended exit code.
- **Fix:** Remove `process.exit()` after `core.setFailed()` so the toolkit can set the proper non-zero exit code, or pass a non-zero code explicitly: `process.exit(1)`.

#### CR-b851c76505a7 · Collection glob excludes existing .mdx content
- **File:** `src/nimbus/content.config.ts` line 323
- **Issue:** The loader pattern was narrowed from `*.{md,mdx}` to `*.md`. The directory `src/content/compatibility-flags/` contains `nodejs-compat.mdx`, which has valid compatibility-flag frontmatter (`name: "Node.js compatibility"`) and will now be silently dropped from the collection.
- **Fix:** Restore `pattern: "*.{md,mdx}"` so the existing `.mdx` compatibility flag is included in the Nimbus build.

---

## Style Guide Review

### Warnings (1)

#### SG-734ad0616028 · Table introduction must be a complete sentence ending in a colon
- **File:** `src/content/changelog/waf/2026-07-21-waf-release.mdx` line 24
- **Issue:** HTML table starts with `<table style="width: 100%">` without any preceding introductory sentence.
- **Fix:** Add a complete sentence before the table ending in a colon, e.g. "This release includes the following rule changes:"

### Suggestions (3)

#### SG-f472c45946e9 · Use the Oxford comma for lists of three or more items
- **File:** `src/content/changelog/waf/2026-07-21-waf-release.mdx` line 9
- **Issue:** Lists three items joined with `and` without a serial comma: `Generic Rules - ... (RCE), Generic Rules - ... (Auth Bypass - 2) and Generic Rules - ... Disclosure`
- **Fix:** Add a comma before `and`: `Generic Rules - ... Disclosure.`

#### SG-d1f815015c79 · Passive voice
- **File:** `src/content/changelog/access/2026-07-20-http-private-apps-l7-auth.mdx` line 13
- **Issue:** Line contains "No configuration change is required" and "The Cloudflare One Client is still required"
- **Fix:** Rewrite in active voice, e.g., "You do not need to change the configuration. You still need the Cloudflare One Client to route traffic..."

#### SG-4d284bf0be2d · Passive voice
- **File:** `src/content/docs/cloudflare-one/access-controls/applications/non-http/self-hosted-private-app.mdx` line 92
- **Issue:** Line adds `session management is [handled in the Cloudflare One Client](#other-non-http-applications)`
- **Fix:** Rewrite in active voice, e.g. `the Cloudflare One Client handles session management`

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (2)
File Issue
bin/post-pr-ci-failure-comment/index.ts line 35 process.exit() overrides failed exit code — The added core.setFailed(...) on line 35 is immediately followed by a no-argument process.exit() on line 36. process.exit() with no argument exits with code 0, which can cause the GitHub Action step to report success even though core.setFailed() sets the failure message and intended exit code. Fix: Remove process.exit() after core.setFailed() so the toolkit can set the proper non-zero exit code, or pass a non-zero code explicitly: process.exit(1).
src/nimbus/content.config.ts line 323 Collection glob excludes existing .mdx content — The loader pattern was narrowed from \*.{md,mdx} to \*.md. The directory src/content/compatibility-flags/ contains nodejs-compat.mdx, which has valid compatibility-flag frontmatter (name: "Node.js compatibility") and will now be silently dropped from the collection. Fix: Restore pattern: "\*.{md,mdx}" so the existing .mdx compatibility flag is included in the Nimbus build.

Conventions

No convention issues found.

Style Guide Review

Warnings (1)
File Issue
changelog/waf/2026-07-21-waf-release.mdx line 24 Table introduction must be a complete sentence ending in a colon — HTML table starts with <table style="width: 100%"> without any preceding introductory sentence. Fix: Add a complete sentence before the table ending in a colon, e.g. "This release includes the following rule changes:"
Suggestions (3)
File Issue
changelog/waf/2026-07-21-waf-release.mdx line 9 Use the Oxford comma for lists of three or more items — Lists three items joined with and without a serial comma: Generic Rules - ... (RCE), Generic Rules - ... (Auth Bypass - 2) and Generic Rules - ... Disclosure Fix: Add a comma before and: Generic Rules - ... Disclosure.
changelog/access/2026-07-20-http-private-apps-l7-auth.mdx line 13 Passive voice — Line contains "No configuration change is required" and "The Cloudflare One Client is still required" Fix: Rewrite in active voice, e.g., "You do not need to change the configuration. You still need the Cloudflare One Client to route traffic..."
cloudflare-one/access-controls/applications/non-http/self-hosted-private-app.mdx line 92 Passive voice — Line adds session management is [handled in the Cloudflare One Client](#other-non-http-applications) Fix: Rewrite in active voice, e.g. the Cloudflare One Client handles session management
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/ @cloudflare/content-engineering, @kodster28, @mvvmm, @colbywhite, @ahaywood, @MohamedH1998
*.ts @cloudflare/content-engineering, @kodster28
* @cloudflare/product-owners

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@diogoascarneiro
diogoascarneiro self-requested a review July 20, 2026 20:27
@MohamedH1998
MohamedH1998 force-pushed the revert/nimbus-to-live branch from 4beb418 to 9886bdd Compare July 21, 2026 12:27
@MohamedH1998
MohamedH1998 requested a review from a team as a code owner July 21, 2026 12:27
@MohamedH1998 MohamedH1998 changed the title revert: nimbus to live DO NOT MERGE: revert: nimbus to live Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants