nimbus: live#32181
Merged
Merged
Conversation
MohamedH1998
requested review from
a team,
ahaywood,
colbywhite,
kodster28 and
mvvmm
as code owners
July 20, 2026 19:32
Contributor
Review🚨 1 critical, Fix in your agentFix the following review findings in PR #32181 (https://github.com/cloudflare/cloudflare-docs/pull/32181).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Code Review
### Critical (1)
#### CR-2e023bfe23fe · Asset directory inconsistent with Worker redirects import
- **File:** `wrangler.jsonc` line 17
- **Issue:** `assets.directory` is changed to `./dist-nimbus`, but `worker/index.ts` (the `main` entry) still imports redirects from `../dist/__redirects`. The Nimbus build outputs to `dist-nimbus/` while the default build outputs to `dist/`, so the production Worker will use stale or missing redirects while serving `dist-nimbus` assets.
- **Fix:** Either update `main` to `worker/index.preview.ts` (which imports `../dist-nimbus/__redirects`) or change `worker/index.ts` to import `../dist-nimbus/__redirects` so redirects and static assets are sourced from the same build output.
### Warnings (1)
#### CR-266a6c612836 · Preview deploy uses default wrangler config for Nimbus artifact
- **File:** `.github/workflows/ci.yml` line 401
- **Issue:** publish-preview now downloads dist-nimbus, but the Deploy to Cloudflare Workers step runs wrangler deploy without --config wrangler.nimbus-preview.json. The separate publish-nimbus-preview job uses that exact config for the same dist-nimbus artifact, so the default config likely expects dist, not dist-nimbus.
- **Fix:** If publish-preview is intended to deploy the Nimbus build, add --config wrangler.nimbus-preview.json to the wrangler deploy commands; otherwise, keep it downloading dist for the default config.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Critical (1)
Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
4 tasks
Contributor
|
Nimbus Preview URL: https://nimbus-e096dd5b.preview.developers.cloudflare.com |
diogoascarneiro
approved these changes
Jul 20, 2026
Contributor
|
Preview URL: https://e096dd5b.preview.developers.cloudflare.com |
Contributor
Author
|
/bonk create a revert PR for this |
Contributor
|
fatal: couldn't find remote ref nimbus/live |
Contributor
|
@MohamedH1998 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
Author
|
/bonk Roll back the Nimbus flip.
Before opening, verify the diff touches EXACTLY these 8 files and nothing else:
|
Contributor
|
fatal: couldn't find remote ref nimbus/live |
MohamedH1998
added a commit
that referenced
this pull request
Jul 21, 2026
This reverts commit 6ef6c18.
MohamedH1998
added a commit
that referenced
this pull request
Jul 21, 2026
This reverts commit 6ef6c18.
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip Nimbus builds to production
Screenshots (optional)
Documentation checklist