chore: tail-end Starlight->Nimbus migration cleanup#32250
Merged
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
Small cleanup pass identified after the Starlight->Nimbus migration
and the src/nimbus->src promotion:
- .github/CODEOWNERS: fix dead /src/nimbus/pages/agent-setup path (no
longer exists post-promotion) to /src/pages/agent-setup. That team
had zero CODEOWNERS coverage on the real directory.
- style-guide/how-we-docs/metadata.mdx: fix dead GitHub link to
src/nimbus/schemas (now src/schemas).
- Batch content fix across 11 style-guide pages that still described
the site as running on Starlight, or referenced now-removed
Starlight/community packages (starlight-package-managers,
starlight-links-validator) instead of their Nimbus/local
equivalents:
- our-site.mdx: framework description now points to nimbus-docs.com
instead of starlight.astro.build (and no longer misattributes a
Hugo->Starlight blog post to a "choosing Nimbus" claim it doesn't
make).
- links.mdx: replaces the removed starlight-links-validator
reference and a dead <GitHubCode> snippet (pinned to an ancient
commit's now-nonexistent line numbers) and a phantom CI env var
link with an accurate description of Nimbus's nimbus/internal-link
rule.
- icons.mdx: replaces a genuinely broken example (`import {
StarlightIcon } from "~/components"` — this export doesn't exist)
with the real Card/LinkCard `icon` string-prop API, and notes the
legacy seti:/bare-name compat mapping for existing content.
- badges.mdx: removes an instruction to apply a `sl-badge` CSS class
that no longer exists on the ported Badge component (styling is
now computed inline via Tailwind, not exposed as a class).
- cards.mdx, file-tree.mdx, package-managers.mdx, rss-button.mdx,
frontmatter/index.mdx, frontmatter/custom-properties.mdx,
directory-listing.mdx, content-types/overview.mdx: swap Starlight
framework/package attributions and dead starlight.astro.build
links for the real Nimbus component/docs equivalents.
- ai-consumability.mdx: the claim that Cloudflare's Markdown-for-
Agents network layer transforms a `starlight-tabs` custom element
is no longer accurate — Nimbus's Tabs component doesn't render
that custom element at all (confirmed: it's a plain `<div
data-nb-tabs>`). Generalized the wording since verifying/fixing
that external transform pipeline is out of scope here; flagging
this as worth a cross-team follow-up separately.
Verified: pnpm run check/lint/format:check/test all clean, full build
succeeds (8709 pages), test:postbuild passes.
mvvmm
force-pushed
the
chore/post-migration-cleanup-followups
branch
from
July 22, 2026 19:59
5767466 to
30dd3e6
Compare
mvvmm
changed the title
mvvmm
marked this pull request as ready for review
July 22, 2026 20:06
Contributor
Review💡 2 suggestions found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #32250 (https://github.com/cloudflare/cloudflare-docs/pull/32250).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-d80037644640 · Redundant external link
- **File:** `src/content/docs/style-guide/frontmatter/index.mdx` line 75
- **Issue:** The added line repeats the same Nimbus frontmatter documentation link that already appears on line 26 of the same page.
- **Fix:** Remove the duplicate link at line 75 so the page references Nimbus's frontmatter documentation only once.
---
## Style Guide Review
### Suggestions (1)
#### SG-dae8ed72eb0f · Active voice
- **File:** `src/content/docs/style-guide/components/icons.mdx` line 35
- **Issue:** Added sentence uses passive voice: "These are automatically mapped to an equivalent iconify icon at build time."
- **Fix:** Rewrite in active voice, for example: "The build automatically maps these to an equivalent iconify icon."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewSuggestions (1)
Acknowledged by author (2)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
kodster28
approved these changes
Jul 22, 2026
Contributor
Author
|
Skipping 2 findings from the code-review bot pass: CR-4ebcc63c55df and CR-57734aec1a56 (unverified Fixing the 2 style-guide findings (SG-1494a493ee02, SG-56958ba6eade) in the next commit. |
…on sentence) - frontmatter/index.mdx: remove 'please' per style guide (avoid please) - components/icons.mdx: split a semicolon-joined sentence into two Skipped 2 code-review findings about the nimbus-docs.com link possibly being dead/unverified — confirmed live and correct, posted reasoning as a PR comment.
|
Thank you Acces me
Noong Huw, Hul 23, 2026, 04:57, isinulat ni vance ***@***.***>
ang:
… Merged #32250 <#32250>
into production.
—
Reply to this email directly, view it on GitHub
<#32250?email_source=notifications&email_token=CEV6D77NILSQVFPIMBPOY7D5GETDFA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBTGQ4TIMJQGI2DLJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-28349410245>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CEV6D73BAWWJZZQOUC3OAWL5GETDFAVCNFSNUABFKJSXA33TNF2G64TZHMZDSMRWG4ZTIMRUHNEXG43VMU5TIOJVGI2TCOBUGIY2C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tail-end cleanup pass identified after the Starlight→Nimbus migration (#32229) and the
src/nimbus→srcpromotion (#32249). Scoped to dead paths and stale style-guide content that still describes the site's old architecture. (Theastro-config.tsI/O optimization and.git-blame-ignore-revsremoval that were originally bundled here have been split into their own PRs: #32252 and #32253.)Dead paths
.github/CODEOWNERS—/src/nimbus/pages/agent-setupno longer exists post-promotion; that team currently has zero CODEOWNERS coverage on the real/src/pages/agent-setupdirectory. Fixed.style-guide/how-we-docs/metadata.mdx— dead GitHub link tosrc/nimbus/schemas(nowsrc/schemas).Style-guide content batch (11 pages)
These pages describe our own component library and framework to authors — several still claimed the site runs on Starlight, or referenced removed community packages (
starlight-package-managers,starlight-links-validator) instead of their Nimbus/local equivalents. Two are genuine functional breaks, not just wording:icons.mdxhad a copy-pasteable example importingStarlightIconfrom~/components— that export doesn't exist. Replaced with the realCard/LinkCardiconstring-prop API.badges.mdxinstructed readers to apply ansl-badgeCSS class to restyle aspan— that class doesn't exist on the portedBadgecomponent anymore (styling is computed inline via Tailwind). Removed the now-broken instruction.ai-consumability.mdxclaimed Cloudflare's Markdown-for-Agents network layer transforms astarlight-tabscustom element — Nimbus'sTabscomponent doesn't render that element at all anymore (verified: it's a plain<div data-nb-tabs>). Generalized the wording rather than asserting something about an external system I can't verify from this repo — worth a cross-team check on whether that transform pipeline still handles Nimbus's actual Tabs markup for AI-agent consumption.cards.mdx,file-tree.mdx,package-managers.mdx,rss-button.mdx,frontmatter/index.mdx,frontmatter/custom-properties.mdx,directory-listing.mdx,content-types/overview.mdx,our-site.mdx,links.mdx) — swapped stale Starlight attributions/links for the real Nimbus equivalents (nimbus-docs.com has its own public docs site).Verification
pnpm run check/lint/format:check/testall cleanpnpm run buildsucceeds locally (8709 pages)pnpm run test:postbuildpassesDocumentation checklist