chore: post-Nimbus migration cleanup#32229
Merged
Merged
Conversation
github-actions
Bot
added
product:workers
github-actions
Bot
assigned
kodster28,
dinasaur404,
irvinebroque,
GregBrimble,
korinne,
MattieTK,
vy-ton,
WalshyDev and
nevikashah
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
mvvmm
marked this pull request as ready for review
July 22, 2026 00:07
mvvmm
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
dinasaur404,
irvinebroque,
korinne,
nevikashah and
vy-ton
as code owners
July 22, 2026 00:07
mvvmm
force-pushed
the
chore/post-nimbus-migration-cleanup
branch
from
July 22, 2026 00:12
83b72c3 to
7cc6778
Compare
mvvmm
requested review from
MohamedH1998,
ahaywood and
colbywhite
as code owners
July 22, 2026 00:12
Contributor
ReviewReviewing new changes (commit |
mvvmm
force-pushed
the
chore/post-nimbus-migration-cleanup
branch
from
July 22, 2026 00:16
7cc6778 to
3ffcab8
Compare
- Delete dead Starlight-leftover src files (middleware, analytics scripts, explain-code, mermaid, MERMAID.md) and the stale starlight-docsearch patch - Rewrite 13 content files off @astrojs/starlight/components and astro-expressive-code/components -> ~/components; remove those two alias entries from astro-config.ts - Remove 33 unused packages: full Starlight/EC ecosystem plus orphaned rehype/remark/hast/unist plugins deleted with the old plugin tree - Fix vitest.config.ts: remove vite-tsconfig-paths (no test file uses ~/ imports); fix post-pr-ci-failure-comment to not check for 'Nimbus Build' job that no longer exists; delete orphaned bin/post-preview-url-comment/ - Remove Starlight rollback safety-nets: theme toggle no longer dual-writes starlight-theme key, BaseLayout no longer migrates from it, PageHead generator now says 'Nimbus v0.2.2', remove experimental.contentIntellisense - Fix sitemap.serializer.ts git log path (src/pages -> src/nimbus/pages) - Update AGENTS.md, agent references, src/nimbus/README.md, MIGRATION.md (deleted), and two content pages with broken GitHub links to deleted paths - Remove dist-nimbus/ from .prettierignore and eslint.config.js
mvvmm
force-pushed
the
chore/post-nimbus-migration-cleanup
branch
from
July 22, 2026 00:28
3ffcab8 to
ea41c4e
Compare
Contributor
MohamedH1998
approved these changes
Jul 22, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-migration cleanup following the Starlight → Nimbus cutover (PRs #32181, #32203). The dual-build-target world is gone; this removes everything that was kept temporarily for rollback safety or migration compatibility.
Dead code deleted
src/middleware/— Astro ignores middleware outsidesrcDirsrc/scripts/analytics*(6 files),explain-code.ts,mermaid.ts,MERMAID.md— superseded bysrc/nimbus/scripts/copiesbin/post-nimbus-preview-url-comment/— renamed tobin/post-preview-url-comment/(dropping the now-redundantnimbus-qualifier); "Nimbus Preview URL" strings in the comment body replaced with "Preview URL"patches/@astrojs+starlight-docsearch+0.7.0.patch— patches a package no longer in the dep treeMIGRATION.md— describes the pre-migration POC with refs to deleted filesnimbus-build-log/nimbus-build.logtobuild-log/build.log33 packages removed
Full Starlight/EC ecosystem (
@astrojs/starlight*,starlight-*,astro-expressive-code,@expressive-code/*,solarflare-theme,astro-breadcrumbs) plus orphaned rehype/remark/hast/unist plugins that were deleted with the old plugin tree (rehype-autolink-headings,rehype-external-links,rehype-remark,rehype-title-figure,remark-gfm,remark-stringify,hast-util-*,hastscript,rehype-parse,rehype-stringify,unist-util-visit-parents,vfile,space-separated-tokens,vite-tsconfig-paths,mdast-util-mdx-expression,just-bash).13 content files had
@astrojs/starlight/components/astro-expressive-code/componentsimports rewritten to~/components; the corresponding alias entries were removed fromastro-config.ts.Starlight rollback safety-nets removed (migration is final):
starlight-themelocalStorage keystarlight-theme<meta generator>now saysNimbus v0.2.2instead ofStarlight v0.40.0experimental.contentIntellisenseremoved (stable in Astro 6, was a no-op)CI/bin bug fixed:
post-pr-ci-failure-commentwas checking for a"Nimbus Build"job that no longer exists in the workflow.Docs updated:
AGENTS.md(framework, directory tree, schema paths, vitest config name, CI steps), agent references (Starlight built-in→Nimbus component),sitemap.serializer.ts(git log path fixed from deletedsrc/pages/*.astrotosrc/nimbus/pages/**/*.astro), 2 content pages with broken GitHub links pointing to deleted paths.Documentation checklist