[Workers] Runtime API: TCP Socket API Docs connect()#8795
Merged
Conversation
irvinebroque
changed the title
(connect()connect()
Deploying with
|
| Latest commit: |
c928cfb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ff8bbb7.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://bib-sockets-docs.cloudflare-docs-7ou.pages.dev |
irvinebroque
commented
May 9, 2023
irvinebroque
commented
May 9, 2023
dom96
approved these changes
May 9, 2023
dom96
left a comment
dom96
left a comment
Contributor
There was a problem hiding this comment.
Thanks for putting this together! There are some things that need to be changed but in general looking good.
Maddy-Cloudflare
changed the title
connect()connect()
deadlypants1973
changed the title
connect()connect()
Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
irvinebroque
commented
May 12, 2023
Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
irvinebroque
marked this pull request as ready for review
May 15, 2023 19:54
Contributor
Author
|
@deadlypants1973 — I'll add the |
irvinebroque
commented
May 15, 2023
deadlypants1973
approved these changes
May 16, 2023
4 tasks
dom96
reviewed
May 16, 2023
elithrar
approved these changes
May 16, 2023
elithrar
reviewed
May 16, 2023
elithrar
reviewed
May 16, 2023
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com> Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
Collaborator
|
Committed suggestions for @irvinebroque so we can merge ahead of #8914 and before 9AM ET :) |
elithrar
added a commit
that referenced
this pull request
May 16, 2023
* add /runtime-apis/connect * Add note about global scope * Add error handling section * Add section about closing sockets with examples of allowHalfOpen * Fix example, add note about --experimental-local * Apply suggestions from code review Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> * Apply suggestions from code review Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> * Remove expectedHostname * Clarify connection between connect() and max open connections * Fix broken link * Move StartTlS considerations up to StartTLS section * Fix error handling code block * Formatting, intro sentence to error handling example * Clarify that existing readers/writers cannot be reused after .startTls() * Rename page from connect to tcp-sockets * Add /protocols page * Edits to /protocols * /runtime-apis/connect -> /runtime-apis/tcp-sockets * Fix broken URL * workers: Apply suggestions from code review Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com> Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> --------- Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> Co-authored-by: Matt Silverlock <msilverlock@cloudflare.com> Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet
/runtime-apis/connect/platform/protocols(Think this is worth adding — "What protocols can I use with Cloudflare Workers?". Will cover HTTP, WebSockets, Outbound TCP, reference Socket Workers blog post)allowHalfOpendifferences (fe93dd3)/platform/protocolssection, and cross-link to that from the/runtime-apis/connectdocs page--experimental-local)After 05/17/23
--experimental-localcaveat