workers: new Databases sidebar section#8914
Merged
Merged
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Deploying with
|
| Latest commit: |
362a930
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://260d6bdc.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://silverlock-database-beta-doc.cloudflare-docs-7ou.pages.dev |
elithrar
force-pushed
the
silverlock/database-beta-docs
branch
from
May 15, 2023 20:00
d8c9e83 to
98c62c4
Compare
irvinebroque
left a comment
irvinebroque
left a comment
Contributor
There was a problem hiding this comment.
Changed the URL for sockets docs from /runtime-apis/connect to /runtime-apis/tcp-sockets (see suggested edits)
Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
elithrar
marked this pull request as ready for review
May 16, 2023 00:51
Collaborator
Author
|
Note: The GitGuardian check is a false positive. |
elithrar
force-pushed
the
silverlock/database-beta-docs
branch
from
May 16, 2023 02:44
da2ea20 to
0e992e6
Compare
dom96
reviewed
May 16, 2023
Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
Collaborator
Author
|
The checks are failing on broken links until #8795 is merged. |
deadlypants1973
approved these changes
May 16, 2023
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
10 tasks
* add /runtime-apis/connect * Add note about global scope * Add error handling section * Add section about closing sockets with examples of allowHalfOpen * Fix example, add note about --experimental-local * Apply suggestions from code review Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> * Apply suggestions from code review Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> * Remove expectedHostname * Clarify connection between connect() and max open connections * Fix broken link * Move StartTlS considerations up to StartTLS section * Fix error handling code block * Formatting, intro sentence to error handling example * Clarify that existing readers/writers cannot be reused after .startTls() * Rename page from connect to tcp-sockets * Add /protocols page * Edits to /protocols * /runtime-apis/connect -> /runtime-apis/tcp-sockets * Fix broken URL * workers: Apply suggestions from code review Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com> Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> --------- Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com> Co-authored-by: Matt Silverlock <msilverlock@cloudflare.com> Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Collaborator
Author
|
Rebased after merging #8795 |
Collaborator
Author
|
PR got hosed. Fixing... |
elithrar
marked this pull request as draft
May 16, 2023 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to go 🏁
/workers/databases/) top-level sidebar navigation to improve how users discover options for database connectivity to Workerspgdriver, including caveatsUpdated navigation: