fix: Preserve --compatibility-flags in the interactive deploy config flow - #14039
Conversation
🦋 Changeset detectedLatest commit: c1b7f69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
LGTM |
|
✅ All changesets look good |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
3ee458e to
c1b7f69
Compare
|
The compatibility-flags fix looks right, but this also changes existing deploy output formatting by adding a leading blank line before the follow-up message in both branches. That is why several entry-point snapshots now have unrelated blank-line changes. Could the output spacing stay as-is and keep the snapshot updates limited to the compatibility-flags cases? That would make the behavioral change easier to review and avoid changing CLI output for deploy flows that are not involved in this bug. |
|
@kiwigitops the leading blank line is a very minor (although unrelated) addition. I could create a separate PR just for that... but that would feel pretty silly to me, moreover the addition of a single newline shouldn't make reviewing this PR that much more complex... if someone from the team feels that the extra newline is problematic I will move remove it and add it in a followup PR |
This comment was marked as spam.
This comment was marked as spam.
emily-shen
left a comment
There was a problem hiding this comment.
This is fixing it for a specific flag (and probably one of the most frequent), but the general problem still exists - there are other flags (routes, triggers, keep_vars etc.) where someone might come across this issue again.
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
#14055 🙂 |
Fixes #[insert GH or internal issue link(s)].
When running
wrangler deploywithout a config file and going through the interactive setup flow, any--compatibility-flagspassed on the command line (e.g.--compatibility-flags=nodejs_compat) were lost in two places:wrangler.jsoncfile did not includecompatibility_flags.--compatibility-flags.Both are now fixed. Compatibility flags are persisted to the generated config and included in the suggested command.
A picture of a cute animal (not mandatory, but encouraged)