Preserve all deployment-affecting CLI flags in the interactive deploy config flow - #14055
Conversation
🦋 Changeset detectedLatest commit: b9ca284 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
|
OK that's fine. The Now let me assess the overall code quality. The implementation looks solid:
I don't see any logic bugs, security issues, backward compatibility violations, or incorrect API behavior. The code is well-structured and the tests are comprehensive. LGTM |
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
@cloudflare/wrangler-bundler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
1cdae4e to
35d4231
Compare
35d4231 to
45993e5
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
When running
wrangler deploywithout a config file and going through the interactive setup flow, CLI flags beyond--compatibility-flags(such as--routes,--triggers,--var,--define,--alias,--jsx-factory,--jsx-fragment,--tsconfig,--minify,--upload-source-maps,--no-bundle,--logpush,--keep-vars,--legacy-env, and--dispatch-namespace) were silently dropped. These flags are now persisted to the generatedwrangler.jsoncconfig file (where a config field equivalent exists) and included in the suggested CLI command when the user declines config file generation.A picture of a cute animal (not mandatory, but encouraged)