Leverage the new BPM shutdown_signal feature in Postgres jobs#2334
Merged
Leverage the new BPM shutdown_signal feature in Postgres jobs#2334
shutdown_signal feature in Postgres jobs#2334Conversation
beyhan
approved these changes
Nov 2, 2021
Contributor
|
@bgandon Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
Now that BPM v1.1.14 is shipped and used in
bosh-deployment, we can use the newshutdown_signalfeature.Please provide contextual information.
SIGINTto shutdown Postgres was recently implemented in: Implement drain scripts for Postgres to properly use the fast shutdown mode #2320shutdown_signalfeature is out: https://github.com/cloudfoundry/bpm-release/releases/tag/v1.1.14bosh-deployment: https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L147-L150What tests have you run against this PR?
How should this change be described in bosh release notes?
shutdown_signalfeature provided by BPM v1.1.14+Does this PR introduce a breaking change?
No.
Tag your pair, your PM, and/or team!
Solo-ed on this.