Conversation
rkoster
requested changes
Jan 27, 2022
Contributor
rkoster
left a comment
rkoster
left a comment
There was a problem hiding this comment.
Looks good, just a few missing quotes here an there
|
|
||
| mkdir -p $DATA_DIR/pg_log | ||
| chown vcap:vcap $DATA_DIR/pg_log | ||
| mkdir -p ${STORE_DIR}/pg_log |
| fi | ||
|
|
||
| echo "host all $USER 0.0.0.0/0 md5" >> $DATA_DIR/pg_hba.conf | ||
| echo "host all $USER 0.0.0.0/0 md5" >> ${STORE_DIR}/pg_hba.conf |
…tent data after successful upgrade to v13
…n with SIGINT (see #2334)
…uire quoting variable expansions
… BPM context and also remove unnecessary mounting of 'postgres-10' folder to prevent it from being recreated at each startup
bgandon
force-pushed
the
pg-prestart-cleanup
branch
from
da55c84 to
0621a51
Compare
Contributor
Author
|
Thank you Ruben for the good catches! |
Contributor
|
Thanks @bgandon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello dear Bosh fellows,
Turns out the Postgres
pre-startscripts were executed twice: first by Bosh Agent asrooton the VM with no restrictions, second inside the BPM context. This issue comes from commit 4ab3193 in the first place, maybe due to lack of review.When fixing this unnecessary duplicate execution of
pre-startscripts, then mounting the old persistent store directory with BPM is no more necessary. This is useful to prevent an emptypostgres-10directory to re-appear at every startup, only because it is declared in BPM for purposes of migrating from v10 to v13.I've also fixed some bugs related to typos, as the actual directory for Postgres 9.4 is
postgres-9.4and notpostgres-9. This was preventing Postgres 10pre-startscript from was properly removing the Postgres 9.4 old persistent data after successful upgrade.Also, after we've merged #2334, some data repair code in migration from Postgres v9.4 to v10 (due to improper signal being previously used to stop Postgres) is no more necessary, so I've removed it.
Less importantly, I've reviewed the
pre-startscripts for the 3 Postgres jobs. I've noticed that the word 'data dir' was used for persistent data, that go to the 'store' dir in Bosh parlance, whereas 'data' dir usually designates the ephemeral data. So, I'm proposing some improved wording in that regards, for cleaner code.Best,
Benjamin