[v8] Allow setting the route destination port via the CF CLI map-route command#3734
Open
sethboyles wants to merge 1 commit intocloudfoundry:v8from
Open
[v8] Allow setting the route destination port via the CF CLI map-route command#3734sethboyles wants to merge 1 commit intocloudfoundry:v8from
sethboyles wants to merge 1 commit intocloudfoundry:v8from
Conversation
…mand using a new app-port parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
v8 port of #3612
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
This PR introduces support for setting the route destination port via the CF CLI map-route command using a new app-port parameter. This functionality is comparable to the existing app-protocol parameter used for setting the destination protocol.
The change enables users to specify the destination port directly when mapping a route to an application.
Why Is This PR Valuable?
This change improves the flexibility of the map-route command by allowing users to configure the destination port for their routes directly from the CLI. This is particularly valuable for applications that require traffic to be routed to specific, non-default ports, aligning the CLI's capabilities with the underlying networking features.
Especially this is useful for docker apps that have multiple ports, where the end user needs to switch tools to configure it via API oder Terraform instead of just using cf push from the command line as long as the CLI and the manifest do not support setting it.
Applicable Issues
How Urgent Is The Change?
Not urgent
Other Relevant Parties
Who else is affected by the change?