Prevent service instance sharers from attempting to share with themselves - #1000
Merged
Conversation
* Raise 422 when source space is included in list of target spaces [#152109683] Signed-off-by: Denise Yu <dyu@pivotal.io>
|
Hey Samze! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/152959594 The labels on this github issue will be updated when the story is started. |
Contributor
Author
|
@elenasharma This is the reopened version of #992 & addresses the rejection of #152759320. Thanks! |
5 tasks
deniseyu
deleted the
restore-pr-service-instance-sharing-no-sharing-to-own-space
branch
November 28, 2017 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the changes that were merged and reverted as part of #992.
It appears that there has been some misunderstanding/confusion. We think this is what happened:
#988 was originally created for this story which resulted in #152759320 being created in CAPI's tracker. That PR was closed by SAPI as it needed reworking, instead #922 was opened. It appears that the original #988, which we assume had the acceptance performed against it, did not function. However we have deployed and checked #992 and it does work. So this PR simply restores the original commit that was reverted.
Hope that makes sense, let us know if you have any questions!
Thanks,
Sapi Team (Sam & @ablease)
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests