Skip to content

Delete roles in Perm when deleting by username - #922

Merged
tcdowney merged 2 commits into
masterfrom
perm/delete-role-by-username
Oct 2, 2017
Merged

Delete roles in Perm when deleting by username#922
tcdowney merged 2 commits into
masterfrom
perm/delete-role-by-username

Conversation

@iredelmeier

Copy link
Copy Markdown
Contributor

[Finishes #150978621, #150978620, #150978619]

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests on bosh lite

[Finishes #150978621, #150978620, #150978619]
@cfdreddbot

Copy link
Copy Markdown

Hey iredelmeier!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151571187

The labels on this github issue will be updated when the story is started.

@elenasharma

Copy link
Copy Markdown
Contributor

Hi @iredelmeier - sending this back to you because when we run our unit tests, we get hundreds of 500 errors instead of successful responses. It seems that there's likely one cause for these failures.

@iredelmeier

Copy link
Copy Markdown
Contributor Author

@elenasharma sorry about that The Gemfile.lock had a newer version of the client. This is what happens when you have other things going on locally and then push right before retro ;) Should be sorted out now!

@iredelmeier iredelmeier mentioned this pull request Sep 29, 2017
4 tasks
@tcdowney
tcdowney merged commit f25fdad into master Oct 2, 2017
@chendrix
chendrix deleted the perm/delete-role-by-username branch October 4, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants