Skip to content

277 dataset thumbnail 404 not found broken link after file deletion#288

Merged
max-zilla merged 5 commits into
developfrom
277-Dataset-Thumbnail-404-Not-Found---Broken-Link-after-File-Deletion
Oct 19, 2021
Merged

277 dataset thumbnail 404 not found broken link after file deletion#288
max-zilla merged 5 commits into
developfrom
277-Dataset-Thumbnail-404-Not-Found---Broken-Link-after-File-Deletion

Conversation

@longshuicy
Copy link
Copy Markdown
Member

Description

First to reproduce this issue, see the latest comment I made at the issue #277

In short, deleting a file used as thumbnail IS FINE :-p.

Only when that image (used as thumbnail) is moved to a folder --> then got deleted causes issues. The reason is being that images inside of the folder are NOT used as thumbnail candidates at the moment; however when moving an existing thumbnail to the folder failed to update that dataset/collection.

To fix that I added additional logic when move file to folders


To test try below steps:

  1. Upload 2 images to the root dataset - you should see the first image being used as thumbnail of the dataset
  2. Create a folder
  3. Move one of the image to the folder - you should see the thumbnail of the dataset changed
  4. Move the other image to the folder - you should see the dataset is without thumbnail anymore
  5. Delete folder/ or delete images inside of the folder - should not be any broken links

you could repeat the above step with dataset within collections, you should see similar results for the collection thumbnail.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@longshuicy longshuicy self-assigned this Oct 7, 2021
@longshuicy longshuicy linked an issue Oct 7, 2021 that may be closed by this pull request
@max-zilla max-zilla merged commit e7cb546 into develop Oct 19, 2021
@max-zilla max-zilla deleted the 277-Dataset-Thumbnail-404-Not-Found---Broken-Link-after-File-Deletion branch October 19, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset Thumbnail 404 Not Found - Broken Link after File Deletion

2 participants