Conversation
Add a delete button visible to organizers on soft-deleted submissions, and guard against None data in delete/soft_delete methods.
django.middleware.common.CommonMiddleware was listed twice in the MIDDLEWARE tuple.
Symptoms when the chain runs twice:
* For users whose django_session.session_data row cannot be verified by
signing.loads (e.g. after a SECRET_KEY rotation), the second pass of
CommonMiddleware.process_response runs against responses for which the
session/messages state ends up half-initialised, surfacing as a generic
500 page with no traceback on every 404 path, every APPEND_SLASH 301,
and assets like /favicon.ico. With-slash URLs that match a real view
return 200 because the corruption is silently swallowed (decode -> {}).
* Content-Length is computed twice on every response.
Removing the duplicate restores the standard middleware behaviour: a
corrupted session decodes to {} once, the user is treated as anonymous,
and 404/redirect responses are returned normally.
prevents leaking the fact a user exists when entered password is invalid Closes #2437
…sage refactor(login): sanitize failed login error message
Quick Documentation Fix
…submissions fix: allow organizers to hard-delete soft-deleted submissions
fix: allow organizers to hard-delete soft-deleted submissions
Remove duplicate CommonMiddleware from MIDDLEWARE
Remove duplicate CommonMiddleware from MIDDLEWARE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Features
Bug Fixes
Documentation