Skip to content

Minor fixes to lesson 3#128

Merged
despo merged 1 commit into
codebar:gh-pagesfrom
charlieegan3:gh-pages
Sep 10, 2014
Merged

Minor fixes to lesson 3#128
despo merged 1 commit into
codebar:gh-pagesfrom
charlieegan3:gh-pages

Conversation

@charlieegan3
Copy link
Copy Markdown
Contributor

-h2 → h1
-b → strong

Note:
It's likely also worth updating the gist at: https://gist.github.com/despo/7328342 to have the adjusted starting styles.

Comment thread html/lesson3/styles.css Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using body instead off ***** means that the students don't come across another new concept.
Also, I would discourage use of the star selector because of performance issues and unexpected results.

-h2 → h1
-b → strong
@charlieegan3
Copy link
Copy Markdown
Contributor Author

@despo have removed the use of the * { } selector

@despo
Copy link
Copy Markdown
Member

despo commented Sep 10, 2014

@charlieegan3 thank you 👍

despo added a commit that referenced this pull request Sep 10, 2014
@despo despo merged commit 37ac69c into codebar:gh-pages Sep 10, 2014
octopusinvitro pushed a commit that referenced this pull request Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants