Skip to content

Minor fixes to lesson 3 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
despo merged 1 commit into from
Sep 10, 2014
Merged

Minor fixes to lesson 3 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions html/lesson3/example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
<img src="assets/images/ada_lovelace.jpg" height="60px"/>
</div>
<div class="title">
<h2>Hi, I'm Ada Lovelace</h2>
<h1>Hi, I'm Ada Lovelace</h1>
</div>
</header>

<div id="container">
<div class="sidebar">
<b> Me on the internet</b>
<strong> Me on the internet</strong>
<ul class="social-media">
<li><a href="https://www.facebook.com/augusta.ada.lovelace">facebook</a> </li>
<li><a href="http://en.wikipedia.org/wiki/Ada_Lovelace">wikipedia</a> </li>
Expand Down
6 changes: 3 additions & 3 deletions html/lesson3/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
body {
font-family: Helvetica, Arial, sans-serif;
padding: 0;
margin: 0;
padding: 0px;
margin: 0px;
line-height: 23px;
}

Expand Down Expand Up @@ -67,7 +67,7 @@ header {
border-left-color: #a26cd2;
}

.sidebar b {
.sidebar strong {
margin-left: 36px;
color: #4c4066;
font-size: 19px;
Expand Down
12 changes: 6 additions & 6 deletions html/lesson3/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ Add an image wrapped in a `<div>` element
</div>
```

Add the heading `<h2>`, underneath the `<div>` wrapping the image, within the `<header>` element
Add the heading `<h1>`, underneath the `<div>` wrapping the image, within the `<header>` element

```html
<div>
<h2>Hi, I'm Ada Lovelace</h2>
<h1>Hi, I'm Ada Lovelace</h1>
</div>
```

Expand Down Expand Up @@ -135,7 +135,7 @@ Make the `div` element surrounding the heading inline. Start by adding a class `

```html
<div class="title">
<h2>Hi, I'm Ada Lovelace</h2>
<h1>Hi, I'm Ada Lovelace</h1>
</div>
```
and then the relevant CSS
Expand All @@ -146,7 +146,7 @@ and then the relevant CSS
}
```

`inline-block` is another display attribute. You must use `inline-block` rather than `inline` to make the element appear inline because the `div` with the class `title` contains a block element, `<h2>`, that takes over and expands across the end of the line.
`inline-block` is another display attribute. You must use `inline-block` rather than `inline` to make the element appear inline because the `div` with the class `title` contains a block element, `<h1>`, that takes over and expands across the end of the line.

> Using firebug, change `inline-block` to `inline` and notice how they render

Expand Down Expand Up @@ -218,7 +218,7 @@ Let's add some content! Add the following inside the `div` in the html file

```html
<div>
<b>Me on the internet</b>
<strong>Me on the internet</strong>
<ul>
<li><a href="https://www.facebook.com/augusta.ada.lovelace">facebook</a> </li>
<li><a href="http://en.wikipedia.org/wiki/Ada_Lovelace">wikipedia</a> </li>
Expand Down Expand Up @@ -574,7 +574,7 @@ footer a {

Have a look at the [example page](http://codebar.github.io/tutorials/html/lesson3/example.html "Ada Lovelace"). The heading and body of the page have some differences from the page we just created.

Use the inspector to have a look at `<body>` and `<h2>` and apply these changes to your page.
Use the inspector to have a look at `<body>` and `<h1>` and apply these changes to your page.

-----

Expand Down