Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Fixed find command not working on Windows.#217

Merged
drazisil merged 1 commit intocodecov:masterfrom
nmoinvaz:fixes/win32-find-param
May 21, 2020
Merged

Fixed find command not working on Windows.#217
drazisil merged 1 commit intocodecov:masterfrom
nmoinvaz:fixes/win32-find-param

Conversation

@nmoinvaz
Copy link
Contributor

@nmoinvaz nmoinvaz commented Nov 7, 2019

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #217   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

@nmoinvaz nmoinvaz changed the title Fixed find command not working on Windows. #167 Fixed find command not working on Windows. Nov 7, 2019
@raczben
Copy link

raczben commented Feb 4, 2020

Why this fix has not been accepted?

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Feb 4, 2020

@raczben you can use my fork which has the fixes if you want.

@raczben
Copy link

raczben commented Feb 18, 2020

No, I just hoped... My issue is https://stackoverflow.com/q/59934305/2506522

@nmoinvaz nmoinvaz mentioned this pull request Apr 22, 2020
Closed
@nmoinvaz nmoinvaz mentioned this pull request May 21, 2020
Closed
@drazisil
Copy link
Contributor

drazisil commented May 21, 2020

@nmoinvaz Can you hunt down and correct the error with the changed method name? If not, I can, but I have several other issues on my plate, so I can't gave a timeline.

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented May 21, 2020 •
edited
Loading

What is the error? It there a rebasing that needs to be done?

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented May 21, 2020

Looks like that is the case.. I will rebase.

@drazisil drazisil merged commit 4d87117 into codecov:master May 21, 2020
@drazisil
Copy link
Contributor

drazisil commented May 21, 2020

@nmoinvaz Thanks! Will cut a new release in a few, I'm fixing an issue where the version is wrong.

@nmoinvaz nmoinvaz mentioned this pull request May 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmoinvaz @raczben @drazisil