Fixed gcov not being found in certain instances.

[nmoinvaz]

See #261

[codecov]

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #263   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1           

[nmoinvaz]

I have rebased my fork and tested again that this fixes it.

[nmoinvaz]

@thomasrockhu this one is also important as it fixes reported bug #261

[nmoinvaz]

Between the time when I first created my PR #217 and when it was pulled, try_to_run command was converted to take a list instead of a string in 6fe18b3.

[thomasrockhu]

Suggested change

	cmd = sanitize_arg("", codecov.gcov_exec or "").split(" ")
	cmd.append("-pb")
	if codecov.gcov_args:
	cmd.append(sanitize_arg("", codecov.gcov_args or ""))
	cmd.append(path)
	cmd = [
	*sanitize_arg("", codecov.gcov_exec or "").split(" "),
	"-pb",
	sanitize_arg("", codecov.gcov_args or ""),
	path,
	]

[nmoinvaz]

That is how I initially had it, but my CI threw some errors with "" entries if gcov_args not supplied. It was trying to find "" as an input file.

Also I split() gcov_exec due to "llvm-cov-6.0 gcov" possibly being passed in.

[thomasrockhu]

ok, with the way it is to unblock users, but would prefer a cleaner look

[nmoinvaz]

Thanks!