feat: support RDP-specific deep links#147
Merged
Merged
Conversation
This was referenced May 5, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1bb58f3 to
f80c296
Compare
f6bc9e3 to
83b1554
Compare
199dd0e to
35afca9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for RDP-specific deep links by parsing and validating a custom URL format and handling credential display and clipboard copy operations for RDP connections. Key changes include:
- Adding deep link parsing and error handling for RDP routes across multiple modules.
- Introducing new error cases such as openError and couldNotCreateRDPURL to better represent RDP failures.
- Extending the menu state with helper functions to find workspaces and agents by name.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Coder-Desktop/VPNLib/FileSync/FileSyncDaemon.swift | Added a comment explaining the location of FileSync code to work around a linking issue. |
| Coder-Desktop/VPNLib/CoderRouter.swift | Extended the router with a new error case (openError) and added error handling improvements for RDP routes. |
| Coder-Desktop/Coder-Desktop/VPN/MenuState.swift | Added helper functions to find agents and workspaces, which are used by the deep link handling. |
| Coder-Desktop/Coder-Desktop/URLHandler.swift | Updated URL handling to process the RDP route, validate connectivity, and manage credentials and clipboard actions. |
Files not reviewed (1)
- scripts/build.sh: Language not supported
deansheather
reviewed
May 6, 2025
83b1554 to
317524f
Compare
d3c0f66 to
4e6d866
Compare
deansheather
approved these changes
May 6, 2025
317524f to
e39714c
Compare
4c372d2 to
d594ee7
Compare
e39714c to
c25ba00
Compare
d594ee7 to
320dac8
Compare
Member
Author
Merge activity
|
320dac8 to
1227eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #96.
If a
coder_appexists on the workspace, where the URL is of the form:coder://dev.coder.com/v0/open/ws/<workspace>/agent/<agent>/rdp?username=administrator&password=passwordthe URL will be parsed, validated, and an alert opened.If
Openis clicked on the alert, the password will be written to the clipboard, where it can be pasted when prompted.rdp.mov
We're unable to avoid the entering of the password, as the
passwordfield in an.rdpfile, even if encrypted properly, is ignored by the macOS Windows RDP app.The app supports reading credentials from the macOS keychain, and whilst we could create keychain entries, they have to be associated with an RDP config in the app, and there's no way to automate the creation of that config, and then run that config.
Further reading:
https://stackoverflow.com/questions/48713606/how-to-create-rdp-file-on-mac-os-that-allows-auto-login
https://techcommunity.microsoft.com/discussions/azurevirtualdesktopforum/macos-remote-desktop-client-app---automatic-logon-no-credential-prompt/2596451
The above demo was done by adding this app to the template: