fix: --max-msgs with generate-only should not throw error#10842
fix: --max-msgs with generate-only should not throw error#10842mergify[bot] merged 31 commits intomasterfrom
--max-msgs with generate-only should not throw error#10842Conversation
atheeshp
changed the title
--max-msgs with generate-only should throw error--max-msgs with generate-only should not throw error
…k into ap/max-msgs-all-rewards
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
lgtm overall, we should add a changelog entry
…k into ap/max-msgs-all-rewards
| suite.Run(t, new(GRPCQueryTestSuite)) | ||
| } | ||
|
|
||
| func TestWithdrawAllSuite(t *testing.T) { |
There was a problem hiding this comment.
Added a new suite here, since there are few tests are failing if I change NumValidators = 2 in existing integration suite (seems like non-determinism) and couldn't test them on local machine since the tests are keep on throwing timeout error.
atheeshp
force-pushed
the
ap/max-msgs-all-rewards
branch
from
9e9c3e4 to
fac4cad
Compare
atheeshp
force-pushed
the
ap/max-msgs-all-rewards
branch
from
c903a9b to
bf2d705
Compare
| fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()), | ||
| fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation), | ||
| fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync), | ||
| fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock), |
There was a problem hiding this comment.
updated this (made changes accordingly), because some times tests are getting timeout with BroadcastSync.
|
@alexanderbez can you have another look please, few changes have been made after your approval. Thanks! |
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
changes lgtm, but the non-determinism/timeouts seems a bit worrying. If we merge this, can we maybe create an issue to track this?
|
ping @alexanderbez, would you have bandwidth to take another look at this PR? |
Are you referring to the simulation non-determinism? If so, yeah that's very worrying and I would hestitate to merge this PR with those failing. But why does a CLI change impact those? |
No, this is not about simulations non-determinism, I was mentioning in integration tests itself there were few tests continuously producing different delegation rewards all the time. |
That shouldn't be possible unless there is variance in how many blocks we wait between txs and/ queries. |
4 participants
Description
Closes: #10841
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change