Merged
Conversation
ghost
self-requested a review
ghost
requested review from
kocubinski and
samricotta
and removed request for
a team
julienrbrt
approved these changes
Aug 17, 2023
client/keys/import.go
Outdated
|
|
||
| func ImportKeyHexCommand() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "import-hex <name> <hex> <key-type>", |
Contributor
There was a problem hiding this comment.
Maybe it is a better UX if the 3rd argument is optional and have a default algo string?
Contributor
Author
There was a problem hiding this comment.
yes, completely agree!! nice catch!
Contributor
Author
There was a problem hiding this comment.
key-type is now a flag with secp256k1 as default value
Contributor
|
Can you make the linter happy? https://github.com/cosmos/cosmos-sdk/actions/runs/5890287333/job/15975092543?pr=17424 You need to run |
facundomedica
approved these changes
Aug 17, 2023
kocubinski
approved these changes
Aug 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 0e05785)
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 0e05785) # Conflicts: # CHANGELOG.md # crypto/keyring/keyring.go # crypto/keyring/keyring_test.go
This was referenced Aug 17, 2023
julienrbrt
pushed a commit
that referenced
this pull request
Aug 17, 2023
julienrbrt
added a commit
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes:
#17195
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change