Skip to content

feat: import hex keys #17424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 11 commits into from
Aug 17, 2023
Merged

feat: import hex keys #17424

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e85b12d
add: import hex keys
JulianToledano Aug 17, 2023
7e23bcb
changelog
JulianToledano Aug 17, 2023
e5b1d2e
add: improve long message
JulianToledano Aug 17, 2023
cac5afd
fix: root test
JulianToledano Aug 17, 2023
325a77d
update: key-type as flag
JulianToledano Aug 17, 2023
df4335e
Merge branch 'main' into feat/hex-keys-import
JulianToledano Aug 17, 2023
22d1a07
fix: lint
JulianToledano Aug 17, 2023
7ec30fa
fix: appName
JulianToledano Aug 17, 2023
fe442f2
lint
JulianToledano Aug 17, 2023
fb8dbf2
Merge branch 'main' into feat/hex-keys-import
JulianToledano Aug 17, 2023
cfb3532
fix: lint
JulianToledano Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add: improve long message
  • Loading branch information
@JulianToledano
JulianToledano committed Aug 17, 2023
commit e5b1d2e135250d04b3f01436a4f7757b794cc2aa
2 changes: 1 addition & 1 deletion client/keys/import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func ImportKeyHexCommand() *cobra.Command {
return &cobra.Command{
Use: "import-hex <name> <hex> <key-type>",
Copy link
Copy Markdown
Contributor

@julienrbrt julienrbrt Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a better UX if the 3rd argument is optional and have a default algo string?

Copy link
Copy Markdown
Contributor Author

@JulianToledano JulianToledano Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, completely agree!! nice catch!

Copy link
Copy Markdown
Contributor Author

@JulianToledano JulianToledano Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key-type is now a flag with secp256k1 as default value

Short: "Import private keys into the local keybase",
Long: "Import hex encoded private key into the local keybase.",
Long: "Import hex encoded private key into the local keybase.\nSupported key-types can be obtained with:\n<appd> list-key-types",
Args: cobra.ExactArgs(3),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientQueryContext(cmd)
Expand Down