Skip to content

Refactor IAVL Pruning#5538

Merged
alexanderbez merged 14 commits intomasterfrom
bez/update-iavl-usage
Jan 22, 2020
Merged

Refactor IAVL Pruning#5538
alexanderbez merged 14 commits intomasterfrom
bez/update-iavl-usage

Conversation

@alexanderbez
Copy link
Copy Markdown
Contributor

@alexanderbez alexanderbez commented Jan 17, 2020

Refactor IAVL pruning per the new IAVL API updates, where IAVL handles pruning natively.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
Copy link
Copy Markdown
Contributor

should this be documented in the cosmos docs, hub docs or both? I have heard some questions in regard to this. @gamarin2

@alexanderbez alexanderbez added R4R and removed WIP labels Jan 22, 2020
@alexanderbez alexanderbez marked this pull request as ready for review January 22, 2020 16:42
@alexanderbez alexanderbez added the T: Performance Performance improvements label Jan 22, 2020
Copy link
Copy Markdown
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown
Contributor

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 👍

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2020

Codecov Report

Merging #5538 into master will decrease coverage by 0.06%.
The diff coverage is 48.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5538      +/-   ##
==========================================
- Coverage   54.18%   54.12%   -0.07%     
==========================================
  Files         313      313              
  Lines       18963    18949      -14     
==========================================
- Hits        10276    10257      -19     
- Misses       7888     7895       +7     
+ Partials      799      797       -2
Impacted Files Coverage Δ
client/keys/utils.go 40.35% <ø> (-8.27%) ⬇️
client/context/context.go 2.22% <0%> (-0.02%) ⬇️
x/auth/types/txbuilder.go 23.4% <0%> (ø) ⬆️
client/keys/update.go 73.33% <100%> (ø) ⬆️
client/keys/add.go 42.28% <100%> (ø) ⬆️
client/keys/show.go 83.9% <100%> (ø) ⬆️
client/keys/import.go 68.42% <100%> (ø) ⬆️
client/keys/delete.go 77.27% <100%> (ø) ⬆️
client/keys/list.go 83.33% <100%> (ø) ⬆️
client/keys/export.go 65.21% <100%> (ø) ⬆️
... and 3 more

@alexanderbez alexanderbez merged commit f18005d into master Jan 22, 2020
@alexanderbez alexanderbez deleted the bez/update-iavl-usage branch January 22, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:Store T: Performance Performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants