Skip to content

Bump SDK master commit#259

Merged
alexanderbez merged 7 commits intomasterfrom
bez/bump-sdk-commit
Jan 22, 2020
Merged

Bump SDK master commit#259
alexanderbez merged 7 commits intomasterfrom
bez/bump-sdk-commit

Conversation

@alexanderbez
Copy link
Copy Markdown
Contributor

Bump SDK master commit (which includes Tendermint 0.33 and IAVL 0.13)


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added R4R dependencies Pull requests that update a dependency file labels Jan 17, 2020
@alexanderbez
Copy link
Copy Markdown
Contributor Author

Would like to see cosmos/cosmos-sdk#5538 merged into the SDK and included in this before we merge.

@alexanderbez alexanderbez added the status: blocked Blocked by an external issue. label Jan 17, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2020

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   68.42%   68.42%           
=======================================
  Files           4        4           
  Lines         513      513           
=======================================
  Hits          351      351           
  Misses        131      131           
  Partials       31       31
Impacted Files Coverage Δ
app/app.go 89.4% <0%> (ø) ⬆️
lcd_test/helpers.go 75.53% <100%> (ø) ⬆️

@alexanderbez alexanderbez merged commit 090c545 into master Jan 22, 2020
@alexanderbez alexanderbez deleted the bez/bump-sdk-commit branch January 22, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file status: blocked Blocked by an external issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants