Tx Height Timeout by alexanderbez · Pull Request #6089 · cosmos/cosmos-sdk

alexanderbez · 2020-04-27T19:10:09Z

Description

rename SigFeeMemoTx to Tx
- new name can be up for discussion, but SigFeeMemoTx is really a poor choice
introduce new TxHeightTimeoutDecorator ante-handler decorator
client updates to allow setting timeout-height

closes: #5339

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez · 2020-07-29T14:53:59Z

Can we proceed with this now @aaronc?

aaronc · 2020-07-29T14:59:56Z

Can we proceed with this now @aaronc?

Yes please!

aaronc · 2020-07-29T15:01:28Z

Because of #6863 we should add the timeout field to StdTx as well.

Although that will require adding to SignDoc as well so as an alternative we can have SIGN_MODE_LEGACY_AMINO_JSON fail if timeout is set.

I don't have a strong preference, but it needs to be addressed.

…-sdk into bez/5339-tx-height-timeout

codecov · 2020-08-03T14:07:45Z

Codecov Report

Merging #6089 into master will increase coverage by 1.08%.
The diff coverage is 65.11%.

@@            Coverage Diff             @@
##           master    #6089      +/-   ##
==========================================
+ Coverage   60.86%   61.94%   +1.08%     
==========================================
  Files         379      519     +140     
  Lines       24737    32088    +7351     
==========================================
+ Hits        15056    19877    +4821     
- Misses       8506    10597    +2091     
- Partials     1175     1614     +439

x/ibc-transfer/client/cli/tx.go

client/flags/flags.go

…-sdk into bez/5339-tx-height-timeout

x/auth/types/stdsignmsg.go

colin-axner

ACK

alexanderbez · 2020-08-07T13:42:06Z

@aaronc, mind taking another look at this?

types/errors/errors.go

x/auth/types/stdtx_test.go

aaronc

ACK 🎉

* Implement TxHeightTimeoutDecorator * Update error message * rename type * set height timeout * update tests * update *SignDoc) * rename * remove dup * fix build * cli updates * rest updates * cl++ * Update x/auth/ante/basic.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update x/auth/ante/basic.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update x/auth/ante/basic.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update x/auth/ante/basic.go Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * rename * rename * remove TimeoutHeight from SignDoc * updates * fix tests * update IBC cmd flags * use omitempty * update godoc * add test case to TestStdSignBytes Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Implement TxHeightTimeoutDecorator

a81a5e7

alexanderbez added WIP C:x/auth labels Apr 27, 2020

alexanderbez self-assigned this Apr 27, 2020

Update error message

a8293ab

webmaster128 mentioned this pull request May 4, 2020

Update ADR 020 to use Any #6111

Merged

11 tasks

aaronc mentioned this pull request May 4, 2020

Protobuf Transaction Signing #6078

Closed

4 tasks

aaronc mentioned this pull request May 13, 2020

Proto Any Tx migration #6213

Closed

27 tasks

stale bot added stale and removed stale labels May 27, 2020

stale bot added the stale label Jun 26, 2020

alexanderbez removed the stale label Jun 26, 2020

alexanderbez removed the WIP label Jul 7, 2020

cosmos deleted a comment from stale bot Jul 29, 2020

alexanderbez added automerge labels Jul 29, 2020

alexanderbez and others added 8 commits July 30, 2020 13:17

Merge branch 'master' into bez/5339-tx-height-timeout

86ca407

Merge branch 'master' into bez/5339-tx-height-timeout

bbb14b1

Merge branch 'master' into bez/5339-tx-height-timeout

6d0f768

rename type

aea2957

Merge branch 'master' into bez/5339-tx-height-timeout

42877e9

set height timeout

fb10fac

Merge branch 'bez/5339-tx-height-timeout' of github.com:cosmos/cosmos…

293b583

…-sdk into bez/5339-tx-height-timeout

update tests

533041e

update *SignDoc)

a9fbfec

AdityaSripal approved these changes Aug 5, 2020

View reviewed changes

x/ibc-transfer/client/cli/tx.go Outdated Show resolved Hide resolved

client/flags/flags.go Show resolved Hide resolved

mergify bot and others added 10 commits August 5, 2020 22:25

Merge branch 'master' into bez/5339-tx-height-timeout

1eb68f5

Merge branch 'master' into bez/5339-tx-height-timeout

fdce5e5

Merge branch 'master' into bez/5339-tx-height-timeout

e962492

Merge branch 'master' into bez/5339-tx-height-timeout

425134e

Merge branch 'master' into bez/5339-tx-height-timeout

2451102

updates

eef9c41

Merge branch 'bez/5339-tx-height-timeout' of github.com:cosmos/cosmos…

0dee48e

…-sdk into bez/5339-tx-height-timeout

Merge branch 'master' into bez/5339-tx-height-timeout

f44fe75

Merge branch 'master' into bez/5339-tx-height-timeout

102550b

fix tests

4b9d9e7

aaronc requested changes Aug 6, 2020

View reviewed changes

x/auth/types/stdsignmsg.go Show resolved Hide resolved

update IBC cmd flags

cc71356

alexanderbez requested review from aaronc and colin-axner August 6, 2020 17:58

use omitempty

405f3e8

colin-axner approved these changes Aug 7, 2020

View reviewed changes

mergify bot added 3 commits August 7, 2020 08:36

Merge branch 'master' into bez/5339-tx-height-timeout

06895aa

Merge branch 'master' into bez/5339-tx-height-timeout

494ba93

Merge branch 'master' into bez/5339-tx-height-timeout

8e6bd76

aaronc reviewed Aug 7, 2020

View reviewed changes

types/errors/errors.go Outdated Show resolved Hide resolved

x/auth/types/stdtx_test.go Show resolved Hide resolved

alexanderbez added 2 commits August 7, 2020 17:59

update godoc

d4715da

add test case to TestStdSignBytes

aa222ab

alexanderbez requested a review from aaronc August 7, 2020 22:00

aaronc approved these changes Aug 7, 2020

View reviewed changes

mergify bot merged commit 9ae1766 into master Aug 7, 2020

mergify bot deleted the bez/5339-tx-height-timeout branch August 7, 2020 23:32

y3fers0n mentioned this pull request Feb 8, 2024

[Cosmos] Add support for timeout_height field trustwallet/wallet-core#3683

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tx Height Timeout#6089

Tx Height Timeout#6089
mergify[bot] merged 47 commits intomasterfrom
bez/5339-tx-height-timeout

alexanderbez commented Apr 27, 2020 •

edited

Loading

Uh oh!

alexanderbez commented Jul 29, 2020

Uh oh!

aaronc commented Jul 29, 2020

Uh oh!

aaronc commented Jul 29, 2020 •

edited

Loading

Uh oh!

codecov bot commented Aug 3, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colin-axner left a comment

Uh oh!

alexanderbez commented Aug 7, 2020

Uh oh!

Uh oh!

Uh oh!

aaronc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

alexanderbez commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

alexanderbez commented Jul 29, 2020

Uh oh!

aaronc commented Jul 29, 2020

Uh oh!

aaronc commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colin-axner left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez commented Aug 7, 2020

Uh oh!

Uh oh!

Uh oh!

aaronc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexanderbez commented Apr 27, 2020 •

edited

Loading

aaronc commented Jul 29, 2020 •

edited

Loading

codecov bot commented Aug 3, 2020 •

edited

Loading