deps: merge changes from main into sdk 50 branch#4273
Merged
colin-axner merged 33 commits intocosmos:feat/upgrade-sdk-v0.50from Aug 7, 2023
Merged
deps: merge changes from main into sdk 50 branch#4273colin-axner merged 33 commits intocosmos:feat/upgrade-sdk-v0.50from
colin-axner merged 33 commits intocosmos:feat/upgrade-sdk-v0.50from
Conversation
removed //nolint:staticcheck from deprecated tags
* docs: added 'tx-encoding.md' file to docs * feat: added tx encoding to frontend * docs: improved tx encoding docs * style(docs): moved tx encoding to bottom * docs: improved tx encoding * docs: improved ica tx encoding docs * docs: in ica tx encoding, added small code blocks around some interface names * docs: improved ica client docs + reordered tx encoding in sidebar * docs(ica/cmd): updated docs of 'generate-packet-data' * docs: improved ica tx encoding docs
…s#4190) * build(deps): Bump google.golang.org/grpc from 1.56.2 to 1.57.0 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.56.2 to 1.57.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.56.2...v1.57.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * bump e2e, go mod tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
…4189) Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
…esting helper fnp (cosmos#4182)
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* imp(ica, transfer): added WithICS4Wrapper api function * docs(ica, transfer): updated 'WithICS4Wrapper's godocs * docs(adr8): updated godocs for withics4wrapper * imp(ica/host): removed withics4wrapper from icahost * style(ica, tranfer): ran golanci-lint * imp(ica/controller_test): added WithICS4Wrapper test * imp(transfer_test): added WithICS4Wrapper test * style(transfer_test, ica/controller_test): added spacing to TestWithICS4Wrapper * feat(ica/host): implemented 'WithICS4Wrapper' * feat(fee): implemented 'WithICS4Wrapper'
…nted (cosmos#4188) * feat(core/port): added PacketDataUnmarshaler interface * feat(transfer): implemented PacketDataUnmarshaler interface in transfer * feat(ica/controller): implemented PacketDataUnmarshaler interface * feat(fee): implemented PacketDataUnmarshaler interface * feat(mock): implemented PacketDataUnmarshaler interface * imp(transfer_test): removed explicit use of callbacks in tests * style(transfer_test): ran golangci-lint * imp(testing/mock): removed ErrorMock for the upstreamed error * style(fee_test): improved test readability * imp(transfer_test): improved test styling and added new test case
* fully enable revive * revive * resolve import shadowing by use of suite as a reciever * unused-receiver * names in parse.go * resolve import shadowing * resolve import shadowing in all places * disable flag-return revive linter * remove all unused receivers * disable modifies-method-receiver * unused-rec * unused-rec * unused-rec * unused-parameter * unused * remove unused-parameter linter * Revert "unused-parameter" This reverts commit 55e6862. * Revert "unused" This reverts commit f3f5acf. * revert a spelling issue caused by using us locale * don't use unused-parameters * don't use unused-parameters * fix a few stragglers and focus in on "return in a defer function" * interfaces -> any. Disable early-return and defer in revive for now. * transfer ibc module * type params * revert unneeded changes * revert unneeded changes * Revert "lint docs same as docs-lint pr" This reverts commit 7ea500c. * fix unused parameters (cleanup) * restore export.go * restore mock.go * resolve linting issues in mock.go * move interchain accounts tests to ica * complete cleanup * cleanup parameters * cleanup parameters * suite -> s * further cleanup * fully cleaned * tidy capability * Update e2e/testvalues/values.go Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> * make e2e match main * make .github match main * Update modules/core/02-client/migrations/v7/solomachine.go Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> * make the e2e folder match main * remove the test instances accidentally added * name unused parameters * don't name something "prefix" when using an import named "prefix" * use string, string instead of named returns, but keep the naming clarity * finish consistency * import suite as testifysuite * Rename suite to testifysuite, fix references. * s -> suite for controller module. * s -> suite for host module. * s -> suite for fee module, clean up additional host references. * s -> suite for transfer. * s -> suite for capability. * s -> suite for 02-client. * s -> suite for 03-connection. * s -> suite, missed cases. * s -> suite, 04-channel. * s -> suite, 05-port. * s -> suite, 23-commitment. * s -> suite, core. * s -> suite, light-client solomachine * s -> suite, light-client tendermint * s -> suite, light-client localhost * s -> suite, testing folder * clean up remaining usages of s. * Add directives to ignore deprecated event attributes. * Allow usage of interface{}. * Fix linting issues after rebase. * Address new linting issues. * Revert renaming of args. Requires separate issue. --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io>
cosmos#4199) * refactor(core/exported): moved packet interfaces to packet.go * feat(core/exported): 'PacketDataProvider' interface added * feat(transfer): PacketDataProvider implemented * feat(ica): implemented PacketDataProvider * style(transfer_test, ica_test): improved test name * docs(core.adr8): updated godocs * style(ica_test): changed a variable name * docs(core.adr8): added missing '.' * imp(transfer): removed type assertion on jsonKey * fix(transfer_test): removed unused test case parameter * docs(transfer): updated godocs * imp(ica): removed type assertion from 'GetCustomPacketData' * imp(transfer_test): improved tests without type assertion * imp(ica_test): improved tests without type assertion * style(transfer_test): changed test case parameter name
…s#4200) * refactor(core/exported): moved packet interfaces to packet.go * feat(core/exported): created PacketData interface * feat(transfer): implemented PacketData for transfer * feat(ica): implemented PacketData * docs(transfer.adr8): updated godocs of GetPacketSender * style(adr8): renamed parameter srcPortID -> sourcePortID * docs(core.adr8): updated godocs for PacketData interface * docs(core.adr8): improved godocs for PacketData interface * docs(core.adr8): updated godocs * docs(transfer.adr8): updated godocs * style(ica_test): removed unneeded comment * docs(ica.adr8): updated godocs * style(ica): fixed revive linter complaint * docs(transfer.adr8): updated GetPacketSender's godocs * style(transfer, ica): ran golangci-lin
…os#4231) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
faddat
requested review from
AdityaSripal,
DimitrisJim,
charleenfei,
chatton,
colin-axner,
crodriguezvega and
damiannolan
as code owners
colin-axner
approved these changes
Aug 3, 2023
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
LGTM thanks @faddat
Looks like the sdk bump is in this pr as well, but I guess that's okay. Capability module can be bumped separately on main once there's a beta1 tag
Contributor
Author
|
@colin-axner -- the sdk bump is here too because I'm passing this PR around as something that I'm using in other upgrades. I'd meant to note that but seems I forgot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings changes from main into the sdk 50
branch and updates cosmos-sdk
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.