ICS4: Channel Upgradability Spec#677
Conversation
| if !IsCompatible(counterpartyChannel, proposedUpgradeChannel) { | ||
| restoreChannel() | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
this seems like leftover code from crossing hellos case handled above?
There was a problem hiding this comment.
Indeed. counterpartyChannel is not defined.
There was a problem hiding this comment.
Sorry my mistake. Needed to define and prove counterpartyChannel earlier. counterpartyChannel is the channel that initiator upgraded to.
proposedUpgradeChannel is the channel that TRY is going to upgrade to.
Similar to the connection upgrade channel there needs to be some check on compatibility that will not be specified here since it is upgrade-specific.
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
mpoke
left a comment
mpoke
left a comment
There was a problem hiding this comment.
Looks good. ACK the protocol. See my comments below.
|
|
||
| // call modules onChanUpgradeAck callback | ||
| module = lookupModule(portIdentifier) | ||
| err = module.onChanUpgradeAck( |
Co-authored-by: Marius Poke <marius.poke@posteo.de>
mpoke
left a comment
mpoke
left a comment
There was a problem hiding this comment.
Great work. Just one minor comment.
4 participants
No description provided.