-
Notifications
You must be signed in to change notification settings - Fork 451
ICS4: Channel Upgradability Spec #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d5408ab
copy over connection upgrade spec and replace connection with channel
AdityaSripal c76e1f3
do core changes, TODO: app changes and callbacks
AdityaSripal 7f5a03e
fix typos
AdityaSripal d6d3a67
call app upgrade callbacks
AdityaSripal 1f7d1c9
fix restoreChannelUnless usage
AdityaSripal 0d5574a
fix state conditional checks on TRY
AdityaSripal 795a0a1
Apply suggestions from code review
AdityaSripal 0a00e31
fix partial review of colin, left out crossing hello remarks
AdityaSripal 55d64a1
Apply suggestions from code review
AdityaSripal b831b23
fix verify functions
AdityaSripal da970b1
fix merge
AdityaSripal d24fd7b
consistent msg names
AdityaSripal 0c8e753
add explicit erroring
AdityaSripal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
add explicit erroring
- Loading branch information
commit 0c8e7534b7073d377a871fced424636d5f2e6d8c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.