fix: resolve discrepancy in lqip between post and main page#2453
fix: resolve discrepancy in lqip between post and main page#2453cotes2020 merged 1 commit intocotes2020:masterfrom
Conversation
|
I was notified today that the PR failed checks; I've updated the PR to resolve the error; I wasn't accounting for putting base64-encoded lqip information directly into the yaml. |
cotes2020
left a comment
There was a problem hiding this comment.
Thanks for reporting this issue! Instead of duplicating the logic from the previous block for the LQIP, a better approach would be to use media_subpath.html to generate the LQIP URL. Similarly, the logic for post.image can be improved in the same way to avoid code duplication.
|
I got a chance to take a look and updated the lqip as you recommended. At your suggestion, I did the same for the main image url. Testing with both lqip images and with the embedded base64 still works, as does the main image. Should be good to go now. Thanks for the guidance! |
…hub.io * 'master' of https://github.com/dainmiller/dainmiller.github.io: Update _config.yml docs: update timezone picker reference (cotes2020#2518) feat: add support for embed spotify (cotes2020#2515) fix: avoid unconfigured social options in sidebar (cotes2020#2507) ci: change filter script to ESM format style: change css color functions to use modern notation ci: migrate eslint and stylelint from codacy to gh-actions style: unify quote style in rollup config chore: complete ESLint v9 configuration fix: resolve discrepancy in lqip between post and main page (cotes2020#2453) fix: correct GoatCounter pageviews extraction (cotes2020#2420) feat(i18n): add locale files for some rtl languages (cotes2020#2415) feat(i18n): add Danish locale (cotes2020#2410) # Conflicts: # .github/workflows/pr-filter.yml # .github/workflows/scripts/pr-filter.js # _config.yml # _posts/2019-08-08-write-a-new-post.md
## [7.4.0](v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([#2515](#2515)) ([cda62e2](cda62e2)) * **i18n:** add Danish locale ([#2410](#2410)) ([f5802b8](f5802b8)) * **i18n:** add locale files for some rtl languages ([#2415](#2415)) ([18c48b4](18c48b4)) ### Bug Fixes * avoid unconfigured social options in sidebar ([#2507](#2507)) ([5f8ec7f](5f8ec7f)) * correct GoatCounter pageviews extraction ([#2420](#2420)) ([c706799](c706799)) * resolve discrepancy in lqip between post and main page ([#2453](#2453)) ([1bac96a](1bac96a)) * restore blurry animation for homepage LQIP ([#2551](#2551)) ([221ca9f](221ca9f)) * **search:** restore full-text search for posts with description ([#2557](#2557)) ([604528e](604528e))
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
## [7.4.0](cotes2020/jekyll-theme-chirpy@v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([cotes2020#2515](cotes2020#2515)) ([34be956](cotes2020@34be956)) * **i18n:** add Danish locale ([cotes2020#2410](cotes2020#2410)) ([759f750](cotes2020@759f750)) * **i18n:** add locale files for some rtl languages ([cotes2020#2415](cotes2020#2415)) ([651301f](cotes2020@651301f)) ### Bug Fixes * avoid unconfigured social options in sidebar ([cotes2020#2507](cotes2020#2507)) ([a184ee8](cotes2020@a184ee8)) * correct GoatCounter pageviews extraction ([cotes2020#2420](cotes2020#2420)) ([aa224c7](cotes2020@aa224c7)) * resolve discrepancy in lqip between post and main page ([cotes2020#2453](cotes2020#2453)) ([3fce3fb](cotes2020@3fce3fb)) * restore blurry animation for homepage LQIP ([cotes2020#2551](cotes2020#2551)) ([9f9a88e](cotes2020@9f9a88e)) * **search:** restore full-text search for posts with description ([cotes2020#2557](cotes2020#2557)) ([7bcc1a7](cotes2020@7bcc1a7))
commit 18ab8fc Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Sun Oct 19 23:15:40 2025 +0000 chore(release): 7.4.0 ## [7.4.0](cotes2020/jekyll-theme-chirpy@v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([#2515](cotes2020/jekyll-theme-chirpy#2515)) ([cda62e2](cotes2020/jekyll-theme-chirpy@cda62e2)) * **i18n:** add Danish locale ([#2410](cotes2020/jekyll-theme-chirpy#2410)) ([f5802b8](cotes2020/jekyll-theme-chirpy@f5802b8)) * **i18n:** add locale files for some rtl languages ([#2415](cotes2020/jekyll-theme-chirpy#2415)) ([18c48b4](cotes2020/jekyll-theme-chirpy@18c48b4)) ### Bug Fixes * avoid unconfigured social options in sidebar ([#2507](cotes2020/jekyll-theme-chirpy#2507)) ([5f8ec7f](cotes2020/jekyll-theme-chirpy@5f8ec7f)) * correct GoatCounter pageviews extraction ([#2420](cotes2020/jekyll-theme-chirpy#2420)) ([c706799](cotes2020/jekyll-theme-chirpy@c706799)) * resolve discrepancy in lqip between post and main page ([#2453](cotes2020/jekyll-theme-chirpy#2453)) ([1bac96a](cotes2020/jekyll-theme-chirpy@1bac96a)) * restore blurry animation for homepage LQIP ([#2551](cotes2020/jekyll-theme-chirpy#2551)) ([221ca9f](cotes2020/jekyll-theme-chirpy@221ca9f)) * **search:** restore full-text search for posts with description ([#2557](cotes2020/jekyll-theme-chirpy#2557)) ([604528e](cotes2020/jekyll-theme-chirpy@604528e)) commit 078cf86 Merge: c0e4756 45cb428 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 07:13:19 2025 +0800 Merge branch 'master' into production commit 45cb428 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 07:11:29 2025 +0800 build(deps): upgrade dependencies commit 3578111 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 05:21:46 2025 +0800 refactor: resolve various StyleLint warnings commit 022b963 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 03:11:12 2025 +0800 build(dev-deps): upgrade dependencies commit aa832c2 Author: Cotes <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 02:55:43 2025 +0800 refactor: update favicon files and documentation (#2558) commit 604528e Author: Cotes <11371340+cotes2020@users.noreply.github.com> Date: Mon Oct 20 02:24:40 2025 +0800 fix(search): restore full-text search for posts with description (#2557) commit b3d7db3 Author: Cotes <11371340+cotes2020@users.noreply.github.com> Date: Fri Oct 17 00:02:12 2025 +0800 refactor: avoid converting media‘s relative paths to absolute paths (#2552) commit ee68395 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 14 05:23:24 2025 +0800 build(deps): bump the gh-actions group across 1 directory with 5 updates (#2550) Bumps the gh-actions group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `4` | `5` | | [actions/setup-node](https://github.com/actions/setup-node) | `4` | `5` | | [github/codeql-action](https://github.com/github/codeql-action) | `3` | `4` | | [actions/github-script](https://github.com/actions/github-script) | `7` | `8` | | [actions/stale](https://github.com/actions/stale) | `9` | `10` | Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) Updates `actions/setup-node` from 4 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) Updates `github/codeql-action` from 3 to 4 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) Updates `actions/github-script` from 7 to 8 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) Updates `actions/stale` from 9 to 10 - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a385ffa Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Tue Oct 14 04:54:48 2025 +0800 chore: improve ESLint config commit f51641b Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Tue Oct 14 04:53:51 2025 +0800 chore: remove deprecated URL commit 221ca9f Author: Cotes <11371340+cotes2020@users.noreply.github.com> Date: Tue Oct 14 04:36:02 2025 +0800 fix: restore blurry animation for homepage LQIP (#2551) commit 4d6c788 Author: Alexander Fuks <kungfux@users.noreply.github.com> Date: Mon Sep 8 23:48:19 2025 +0400 docs: update timezone picker reference (#2518) commit cda62e2 Author: Alexander Fuks <kungfux@users.noreply.github.com> Date: Mon Sep 8 23:45:20 2025 +0400 feat: add support for embed spotify (#2515) commit 5f8ec7f Author: Jason Raveling <jason@webunraveling.com> Date: Sun Aug 31 08:51:01 2025 -0500 fix: avoid unconfigured social options in sidebar (#2507) commit eaf5e57 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Thu Jul 31 03:37:32 2025 +0800 ci: change filter script to ESM format Because `"type": "module"` was added to `package.json` commit 29bf95e Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Sun Jul 27 21:39:00 2025 +0800 style: change css color functions to use modern notation - `rgba()` → `rgb()` commit 648398c Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Sun Jul 27 01:11:55 2025 +0800 ci: migrate eslint and stylelint from codacy to gh-actions commit b855e8b Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Sun Jul 27 00:55:54 2025 +0800 style: unify quote style in rollup config commit 49519d1 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Sat Jul 26 20:49:56 2025 +0800 chore: complete ESLint v9 configuration commit 8bf72fc Merge: 1bac96a c0e4756 Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Sat Jul 26 12:25:02 2025 +0000 Merge branch 'production' commit 1bac96a Author: Josh Wickham <josh@i-josh.com> Date: Fri Jun 27 08:58:10 2025 -0700 fix: resolve discrepancy in lqip between post and main page (#2453) commit c706799 Author: Alexander Fuks <kungfux@users.noreply.github.com> Date: Sun Jun 1 00:51:43 2025 +0400 fix: correct GoatCounter pageviews extraction (#2420) commit 18c48b4 Author: Zakaria Fatahi <zakaria@buzzjective.com> Date: Wed May 21 19:06:12 2025 +0200 feat(i18n): add locale files for some rtl languages (#2415) commit f5802b8 Author: Nicolai Skødt Holmgaard <24588044+Nicolai9852@users.noreply.github.com> Date: Wed May 21 19:03:29 2025 +0200 feat(i18n): add Danish locale (#2410) commit 09948da Merge: 519e4f1 53770e4 Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Sun May 18 21:32:02 2025 +0800 Merge branch 'production'
Features: - add support for embed spotify ([#2615](cotes2020/jekyll-theme-chirpy#2515)) Bug Fixes: - avoid unconfigured social options in sidebar ([#2507](cotes2020/jekyll-theme-chirpy#2507)) - correct GoatCounter pageviews extraction ([#2420](cotes2020/jekyll-theme-chirpy#2420)) - resolve discrepancy in lqip between post and main page ([#2453](cotes2020/jekyll-theme-chirpy#2453)) - restore blurry animation for homepage LQIP ([#2551](cotes2020/jekyll-theme-chirpy#2551)) - **search**: restore full-text search for posts with description ([#2557](cotes2020/jekyll-theme-chirpy#2557))
* feat: add support for embed spotify (cotes2020#2515) * docs: update timezone picker reference (cotes2020#2518) * fix: restore blurry animation for homepage LQIP (cotes2020#2551) * chore: remove deprecated URL * chore: improve ESLint config * build(deps): bump the gh-actions group across 1 directory with 5 updates (cotes2020#2550) Bumps the gh-actions group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `4` | `5` | | [actions/setup-node](https://github.com/actions/setup-node) | `4` | `5` | | [github/codeql-action](https://github.com/github/codeql-action) | `3` | `4` | | [actions/github-script](https://github.com/actions/github-script) | `7` | `8` | | [actions/stale](https://github.com/actions/stale) | `9` | `10` | Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) Updates `actions/setup-node` from 4 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) Updates `github/codeql-action` from 3 to 4 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) Updates `actions/github-script` from 7 to 8 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) Updates `actions/stale` from 9 to 10 - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major dependency-group: gh-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: avoid converting media‘s relative paths to absolute paths (cotes2020#2552) * fix(search): restore full-text search for posts with description (cotes2020#2557) * refactor: update favicon files and documentation (cotes2020#2558) * build(dev-deps): upgrade dependencies * refactor: resolve various StyleLint warnings * build(deps): upgrade dependencies * chore(release): 7.4.0 ## [7.4.0](cotes2020/jekyll-theme-chirpy@v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([cotes2020#2515](cotes2020#2515)) ([cda62e2](cotes2020@cda62e2)) * **i18n:** add Danish locale ([cotes2020#2410](cotes2020#2410)) ([f5802b8](cotes2020@f5802b8)) * **i18n:** add locale files for some rtl languages ([cotes2020#2415](cotes2020#2415)) ([18c48b4](cotes2020@18c48b4)) ### Bug Fixes * avoid unconfigured social options in sidebar ([cotes2020#2507](cotes2020#2507)) ([5f8ec7f](cotes2020@5f8ec7f)) * correct GoatCounter pageviews extraction ([cotes2020#2420](cotes2020#2420)) ([c706799](cotes2020@c706799)) * resolve discrepancy in lqip between post and main page ([cotes2020#2453](cotes2020#2453)) ([1bac96a](cotes2020@1bac96a)) * restore blurry animation for homepage LQIP ([cotes2020#2551](cotes2020#2551)) ([221ca9f](cotes2020@221ca9f)) * **search:** restore full-text search for posts with description ([cotes2020#2557](cotes2020#2557)) ([604528e](cotes2020@604528e)) * Revert "refactor: avoid converting media‘s relative paths to absolute paths (cotes2020#2552)" This reverts commit b3d7db3. * fix: avoid duplicate base URL for homepage preview images (cotes2020#2568) * chore(release): 7.4.1 ## [7.4.1](cotes2020/jekyll-theme-chirpy@v7.4.0...v7.4.1) (2025-10-26) ### Bug Fixes * avoid duplicate base URL for homepage preview images ([cotes2020#2568](cotes2020#2568)) ([66bf232](cotes2020@66bf232)) * chore: bump version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexander Fuks <kungfux@users.noreply.github.com> Co-authored-by: Cotes <11371340+cotes2020@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
## [7.4.0](cotes2020/jekyll-theme-chirpy@v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([cotes2020#2515](cotes2020#2515)) ([cda62e2](cotes2020@cda62e2)) * **i18n:** add Danish locale ([cotes2020#2410](cotes2020#2410)) ([f5802b8](cotes2020@f5802b8)) * **i18n:** add locale files for some rtl languages ([cotes2020#2415](cotes2020#2415)) ([18c48b4](cotes2020@18c48b4)) ### Bug Fixes * avoid unconfigured social options in sidebar ([cotes2020#2507](cotes2020#2507)) ([5f8ec7f](cotes2020@5f8ec7f)) * correct GoatCounter pageviews extraction ([cotes2020#2420](cotes2020#2420)) ([c706799](cotes2020@c706799)) * resolve discrepancy in lqip between post and main page ([cotes2020#2453](cotes2020#2453)) ([1bac96a](cotes2020@1bac96a)) * restore blurry animation for homepage LQIP ([cotes2020#2551](cotes2020#2551)) ([221ca9f](cotes2020@221ca9f)) * **search:** restore full-text search for posts with description ([cotes2020#2557](cotes2020#2557)) ([604528e](cotes2020@604528e))
## [7.4.0](cotes2020/jekyll-theme-chirpy@v7.3.1...v7.4.0) (2025-10-19) ### Features * add support for embed spotify ([cotes2020#2515](cotes2020#2515)) ([cda62e2](cotes2020@cda62e2)) * **i18n:** add Danish locale ([cotes2020#2410](cotes2020#2410)) ([f5802b8](cotes2020@f5802b8)) * **i18n:** add locale files for some rtl languages ([cotes2020#2415](cotes2020#2415)) ([18c48b4](cotes2020@18c48b4)) ### Bug Fixes * avoid unconfigured social options in sidebar ([cotes2020#2507](cotes2020#2507)) ([5f8ec7f](cotes2020@5f8ec7f)) * correct GoatCounter pageviews extraction ([cotes2020#2420](cotes2020#2420)) ([c706799](cotes2020@c706799)) * resolve discrepancy in lqip between post and main page ([cotes2020#2453](cotes2020#2453)) ([1bac96a](cotes2020@1bac96a)) * restore blurry animation for homepage LQIP ([cotes2020#2551](cotes2020#2551)) ([221ca9f](cotes2020@221ca9f)) * **search:** restore full-text search for posts with description ([cotes2020#2557](cotes2020#2557)) ([604528e](cotes2020@604528e))
Type of change
Description
As outlined in the issue linked below, the main index page does not consider the media_subpath of the post when rendering the lqip for the preview image, but it does do this when rendering the actual image. This discrepancy makes it impossible to get lqip working in the main post listing and in each post while using the media_subpath property.
This PR fixes that issue by using the same logic to add the media_subpath as currently exists on the post preview image. I have tested this locally and the resulting behavior is now correct; the lqip image shows up until the full sized image is loaded, both when using the media_subpath and when not using that property.
Additional context
Fixes #2449