Update Talos Linux v1.11.3 - #1527
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Summary of ChangesHello Andrei Kvapil (@kvaps), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update, upgrading the underlying Talos Linux operating system to its latest stable version, v1.11.3. This ensures that all deployment artifacts and system extensions are aligned with the most current and secure release of Talos Linux, providing improved stability and access to new features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughSix Talos installer profile YAML files are updated from version v1.10.6 to v1.11.3, with corresponding baseInstaller imageRef updates, systemExtensions list replacements featuring newer image tags (20250917 and v1.11.3 variants), and addition of output format specifications. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The changes follow a consistent, repetitive pattern across all six profile files (version/imageRef bumps and systemExtensions list replacement), which reduces per-file review complexity. However, validation of new image digest values and tags against upstream Talos/Siderolabs releases is required to ensure correctness and compatibility. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates Talos Linux to version v1.11.3 and its associated system extension images across various profile configurations. The changes are consistent and correctly applied across all modified YAML files. My main feedback is regarding the significant code duplication in the configuration files. While these files are auto-generated, the duplication poses a maintainability challenge. I've added a specific comment with a suggestion to refactor the generation script to centralize the common configuration, which would make future updates easier and less error-prone.
| - imageRef: ghcr.io/siderolabs/amd-ucode:20250917@sha256:ff11ee9f1565d9f9b095a3dc41fb7962b211169b2ef05d658a488398cb98e2d2 | ||
| - imageRef: ghcr.io/siderolabs/amdgpu:20250917-v1.11.3@sha256:527b694ddbc4b40e9529d736bfe9874cc786773aa5a1070bbefe77feb9a8a304 | ||
| - imageRef: ghcr.io/siderolabs/bnx2-bnx2x:20250917@sha256:ac6aaaa0d3312e72279a5cde7de0d71fb61774aa2f97a4e56dd914a9f1dde4d1 | ||
| - imageRef: ghcr.io/siderolabs/intel-ice-firmware:20250917@sha256:c25225c371e81485c64f339864ede410b560f07eb0fc2702a73315e977a6323d | ||
| - imageRef: ghcr.io/siderolabs/i915:20250917-v1.11.3@sha256:e8db985ff2ef702d5f3989b0138e1b9dd5ac5e885a3adefa5b42ee6fa32b7027 | ||
| - imageRef: ghcr.io/siderolabs/intel-ucode:20250812@sha256:31142ac037235e6779eea9f638e6399080a1f09e7c323ffa30b37488004057a5 | ||
| - imageRef: ghcr.io/siderolabs/qlogic-firmware:20250917@sha256:7094e5db6931a1b68240416b65ddc0f3b546bd9b8520e3cfb1ddebcbfc83e890 | ||
| - imageRef: ghcr.io/siderolabs/drbd:9.2.14-v1.11.3@sha256:4393756875751e2664a04e96c1ccff84c99958ca819dd93b46b82ad8f3b4be67 | ||
| - imageRef: ghcr.io/siderolabs/zfs:2.3.3-v1.11.3@sha256:3c0b34a760914980ac234e66f130d829e428018e46420b7bca33219b1cc2dd87 | ||
| - imageRef: ghcr.io/siderolabs/lldpd:1.0.20@sha256:4c6370518f5b2e1f03214a6ed54778eaea663fda8850e3f4da174ed69b636172 |
There was a problem hiding this comment.
This list of system extensions is duplicated across all profile files (initramfs.yaml, installer.yaml, iso.yaml, kernel.yaml, metal.yaml, nocloud.yaml). While I understand these files are auto-generated (as noted by the comment at the top of the file), this duplication makes maintenance harder. For example, updating a single extension requires changes in many places, increasing the chance of errors.
Consider refactoring the generation script (packages/core/installer/hack/gen-profiles.sh) to avoid this duplication. One approach could be to use a common YAML file for shared configurations and merge it into each profile during generation. This would improve maintainability and reduce the potential for inconsistencies.
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
Release note
Summary by CodeRabbit