[core] rm talos lldp extension - #1586
Conversation
Signed-off-by: nbykov0 <166552198+nbykov0@users.noreply.github.com>
dosubot
Bot
added
the
size/S
WalkthroughThis pull request removes the Link Layer Discovery Protocol daemon (lldpd) system extension from Talos cluster configuration across multiple build profiles and kernel module patches, eliminating lldpd from being compiled, loaded, and distributed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
💤 Files with no reviewable changes (7)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Nikita (@nbykov0), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on streamlining the Talos core components by entirely removing the LLDP (Link Layer Discovery Protocol) extension. The change simplifies the system by eliminating all associated configurations and build steps for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the Talos lldp extension. The changes are consistent across all modified files, including the end-to-end test cluster preparation script, the profile generation script, and all the generated profile YAML files. The removal of the lldpd extension and its associated image references is done correctly. The changes are straightforward and I have no further comments.
Andrei Kvapil (kvaps)
added
the
backport
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-0.37
git worktree add -d .worktree/backport-1586-to-release-0.37 origin/release-0.37
cd .worktree/backport-1586-to-release-0.37
git switch --create backport-1586-to-release-0.37
git cherry-pick -x c19cddf08e8335f3f6c550cb79eddf0471391c98 |
<!-- Thank you for making a contribution! Here are some tips for you: - Start the PR title with the [label] of Cozystack component: - For system components: [platform], [system], [linstor], [cilium], [kube-ovn], [dashboard], [cluster-api], etc. - For managed apps: [apps], [tenant], [kubernetes], [postgres], [virtual-machine] etc. - For development and maintenance: [tests], [ci], [docs], [maintenance]. - If it's a work in progress, consider creating this PR as a draft. - Don't hesistate to ask for opinion and review in the community chats, even if it's still a draft. - Add the label `backport` if it's a bugfix that needs to be backported to a previous version. --> Removes Talos lldp extension. Please build a custom talos image with factory.talos.dev if you need it. <!-- Write a release note: - Explain what has changed internally and for users. - Start with the same [label] as in the PR title - Follow the guidelines at https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md. --> ```release-note Talos lldp extension removed. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Chores** * Removed LLDPD (Link Layer Discovery Protocol Daemon) system extension from cluster configuration. This eliminates the LLDPD kernel module from cluster setups, removes LLDPD references from build processes, and updates installation profiles across all supported deployment methods including bare metal, cloud environments, and ISO installations, resulting in a reduced system footprint. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
What this PR does
Removes Talos lldp extension.
Release note
Summary by CodeRabbit