Bump Go to v1.24, and golangci-lint to v2.2.1#211
Conversation
negz
changed the title
negz
force-pushed
the
bump
branch
2 times, most recently
from
48fdcf7 to
e687a62
Compare
Signed-off-by: Nic Cope <nicc@rk0n.org>
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
Looks reasonable enough, but would appreciate any insight you have about caching - if you already have it handy that is :)
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
|
|
||
| - name: Find the Go Build Cache |
There was a problem hiding this comment.
i understand go 1.24 has nice new external caching support, so I assume that's why these explicit caching steps are being removed, but I'm having trouble finding anything that says how it works in a github actions environment. do you already have resource like that on hand?
There was a problem hiding this comment.
The setup-go action handles this now magically - https://github.com/actions/setup-go?tab=readme-ov-file#caching-dependency-files-and-build-outputs
| // determine their apiVersion and kind. | ||
| v1beta2.AddToScheme(Scheme) | ||
|
|
||
| // Output: |
There was a problem hiding this comment.
is this leftover from operations work ongoing at the same time?
There was a problem hiding this comment.
No, a linter complained that the example needs an Output block to be valid for go test, which can test examples. In this case it expects no output.
2 participants
Description of your changes
Bump the things, fix the newly detected linter issues.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested