Support operation functions#212
Merged
Merged
Conversation
negz
force-pushed
the
operational
branch
2 times, most recently
from
67cc65c to
f5bf937
Compare
negz
force-pushed
the
operational
branch
2 times, most recently
from
8b723bd to
ad1c2fd
Compare
2 tasks
This is still WIP at the client end in crossplane/crossplane#6594. Signed-off-by: Nic Cope <nicc@rk0n.org>
jbw976
reviewed
Jul 14, 2025
| syntax = "proto3"; | ||
|
|
||
| //buf:lint:ignore PACKAGE_DIRECTORY_MATCH // Too late to fix this now. | ||
| // This package defines the RPC for both composition and operation functions. |
Member
There was a problem hiding this comment.
refresh my memory - is the protobuf stuff just copied over from c/c repo?
| "github.com/crossplane/function-sdk-go/resource" | ||
| ) | ||
|
|
||
| func TestSetDesiredResources(t *testing.T) { |
Member
There was a problem hiding this comment.
worth adding a test for SetDesiredComposedResources while we're in here?
Member
Author
There was a problem hiding this comment.
We should but given time crunch I'm gonna leave it absent. 😬
jbw976
approved these changes
Jul 14, 2025
jbw976
left a comment
jbw976
left a comment
Member
There was a problem hiding this comment.
Seems reasonable here too - i like how much the operations functions are similar to composition functions, reducing a lot of additional new complexity 🤓
This was referenced Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
See corresponding upstream PR: crossplane/crossplane#6594
I cherry-picked #211 into this PR to bump its Go dependency - please review that one first. 😄
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested