Skip to content

[4.0] keystone: Use correct paths when syncing certs#2145

Closed
skazi0 wants to merge 1 commit into
crowbar:stable/4.0from
skazi0:sync-certs-path-fix
Closed

[4.0] keystone: Use correct paths when syncing certs#2145
skazi0 wants to merge 1 commit into
crowbar:stable/4.0from
skazi0:sync-certs-path-fix

Conversation

@skazi0

@skazi0 skazi0 commented May 31, 2019

Copy link
Copy Markdown
Member

The sync failed when certs and/or keys were located in non-default paths.

Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
@skazi0 skazi0 force-pushed the sync-certs-path-fix branch from 2780acd to cf29575 Compare May 31, 2019 16:47
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
@JanZerebecki

Copy link
Copy Markdown
Contributor

@ skazi0 found that this bug was uncovered by SUSE-Cloud/automation@4194b0e from SUSE-Cloud/automation#3194 .

JanZerebecki
JanZerebecki previously approved these changes May 31, 2019
@toabctl toabctl requested a review from cmurphy May 31, 2019 17:26
toabctl
toabctl previously approved these changes May 31, 2019
nicolasbock
nicolasbock previously approved these changes May 31, 2019

@nicolasbock nicolasbock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JanZerebecki

Copy link
Copy Markdown
Contributor

This isn't needed for SOC8 nor 9, because of #1204 .

@skazi0 skazi0 changed the title keystone: Use correct paths when syncing certs [4.0] keystone: Use correct paths when syncing certs Jun 1, 2019
@JanZerebecki

Copy link
Copy Markdown
Contributor

Responding to #2146 (comment) :
This PR is in response to ci ha job failing with:

Errno::ENOENT: ruby_block[synchronize signing keys for founder and remember them for non-HA case] (keystone::server line 347) had an error: Errno::ENOENT: No such file or directory @ rb_sysopen - /etc/keystone/ssl/certs/ca.pem

E.g. in https://ci.suse.de/job/openstack-mkcloud/171079/parsed_console/ testing #2144 .

@JanZerebecki

Copy link
Copy Markdown
Contributor

cmurphy pointed out in the comment linked above that the here modified lines are not about https, which means it changes it to the wrong certificates.
Maybe the postinst script calling pki_setup https://build.opensuse.org/package/view_file/Cloud:OpenStack:Newton/openstack-keystone/openstack-keystone.spec?expand=1 failed?

@skazi0

skazi0 commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

@cmurphy @JanZerebecki ah, now I get it. I got confused because node[:keystone][:ssl] and node[:keystone][:signing] have the same values by default. I will change this PR but it will probably not work as automation scripts don't set those values correctly in signing section.

The sync failed when certs and/or keys were located in non-default paths.
@skazi0 skazi0 dismissed stale reviews from nicolasbock, toabctl, and JanZerebecki via 9119edf June 4, 2019 11:52
@skazi0 skazi0 force-pushed the sync-certs-path-fix branch from cf29575 to 9119edf Compare June 4, 2019 11:52
@skazi0

skazi0 commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

Updated version uses signing section but SUSE-Cloud/automation#3467 is needed before it could work.

@skazi0 skazi0 closed this Jun 5, 2019
@skazi0

skazi0 commented Jun 5, 2019

Copy link
Copy Markdown
Member Author

This PR was closed as the only commit here was moved to #2146 to avoid cross-PR dependencies in gating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants