Skip to content

[4.0] rabbitmq: Fix ACL of SSL key after uid/gid change + keystone: Use correct paths when syncing certs#2146

Merged
skazi0 merged 2 commits into
crowbar:stable/4.0from
skazi0:rabbitmq-ssl-group-fix
Jun 6, 2019
Merged

[4.0] rabbitmq: Fix ACL of SSL key after uid/gid change + keystone: Use correct paths when syncing certs#2146
skazi0 merged 2 commits into
crowbar:stable/4.0from
skazi0:rabbitmq-ssl-group-fix

Conversation

@skazi0

@skazi0 skazi0 commented Jun 3, 2019

Copy link
Copy Markdown
Member

In shared storage based HA setup, rabbitmq uses fixed uid/gid=91.
This user/group modification was done after (optional) SSL certificate
generation. The ACLs on the SSL key were incorrect making rabbitmq
unable to start because with EACCESS errors.

Second commit is taken from #2145 to avoid cross-PR dependencies in gating.

The sync failed when certs and/or keys were located in non-default paths.

Note: forward ports need to include only the rabbitmq part as the keystone change is not relevant for newer versions.

In shared storage based HA setup, rabbitmq uses fixed uid/gid=91.
This user/group modification was done after (optional) SSL certificate
generation. The ACLs on the SSL key were incorrect making rabbitmq
unable to start because with EACCESS errors.
@skazi0

skazi0 commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

This will hopefully fix the HA gating failures we have in stable/4.0 branch. In later branches rabbitmq uses native clustering by default and this mode doesn't use the static uid/gid code so the problem doesn't show there.

@JanZerebecki JanZerebecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to forward-port (if that applies) once it passes CI.

@JanZerebecki JanZerebecki changed the title rabbitmq: Fix ACL of SSL key after uid/gid change [4.0] rabbitmq: Fix ACL of SSL key after uid/gid change Jun 3, 2019
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
Comment thread chef/cookbooks/keystone/recipes/server.rb Outdated
@skazi0

skazi0 commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

Temporarily added this fix #2145 as both are probably needed to have the gating pass.

@cmurphy cmurphy requested a review from stefannica June 3, 2019 19:26
@cmurphy

cmurphy commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

Can you clarify more what the issue was that the commit "keystone: Use correct paths when syncing certs" is fixing? That part of the code isn't doing HTTPS but actually configuration needed for PKI token signing.

I think we're also supposed to fix in master first and then backport?

@skazi0

skazi0 commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

@cmurphy adding to Jan's comment, the problem is that gating jobs have (recently) enabled want_all_ssl which triggered all kinds of SSL failures. In SOC7 it covered some code paths which seem not to be tested very well. In later branches those parts are either removed or not used by default so these problems didn't pop up earlier.

As for the porting strategy... note that we have two sets of labels (forward/back ports). IMO the bugs should be fixed where it's mostly relevant and then ported wherever suitable. This approach was used especially in upgrade related work where we were doing lots of changes in the stable branches.

The sync failed when certs and/or keys were located in non-default paths.
@skazi0 skazi0 force-pushed the rabbitmq-ssl-group-fix branch from 68aead3 to 375f8a8 Compare June 4, 2019 12:02
@skazi0

skazi0 commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

Replaced cherry-picked commit with updated one.

@skazi0 skazi0 changed the title [4.0] rabbitmq: Fix ACL of SSL key after uid/gid change [4.0] rabbitmq: Fix ACL of SSL key after uid/gid change + keystone: Use correct paths when syncing certs #2145 Jun 5, 2019
@skazi0 skazi0 changed the title [4.0] rabbitmq: Fix ACL of SSL key after uid/gid change + keystone: Use correct paths when syncing certs #2145 [4.0] rabbitmq: Fix ACL of SSL key after uid/gid change + keystone: Use correct paths when syncing certs Jun 5, 2019
@skazi0 skazi0 requested a review from JanZerebecki June 5, 2019 05:20
@skazi0 skazi0 merged commit 81dc9e3 into crowbar:stable/4.0 Jun 6, 2019
@skazi0

skazi0 commented Jul 10, 2019

Copy link
Copy Markdown
Member Author

@skazi0 related issue: SOC-9026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants