Skip to content

Added grand scope#2130

Merged
pokey merged 8 commits into
mainfrom
grandScope
Dec 18, 2023
Merged

Added grand scope#2130
pokey merged 8 commits into
mainfrom
grandScope

Conversation

@AndreasArvidsson
Copy link
Copy Markdown
Member

@AndreasArvidsson AndreasArvidsson commented Dec 13, 2023

change grand statement

Checklist

Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to see it was almost as easy as I had hoped 😄. Left a couple comments

Comment thread cursorless-talon/src/modifiers/simple_scope_modifier.py Outdated
Comment thread packages/cursorless-engine/src/generateSpokenForm/primitiveTargetToSpokenForm.ts Outdated
@AndreasArvidsson AndreasArvidsson linked an issue Dec 14, 2023 that may be closed by this pull request
Comment thread cursorless-talon/src/spoken_forms.json Outdated
Copy link
Copy Markdown
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@pokey pokey added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 86266ce Dec 18, 2023
@pokey pokey deleted the grandScope branch December 18, 2023 18:20
cursorless-bot pushed a commit that referenced this pull request Dec 18, 2023
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for “grand” scopes

3 participants