Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates versioning configuration and dependency management to improve version handling and CI pipeline flexibility. The changes modernize the versioning scheme to better support development builds and streamline dependency organization.
- Renamed dependency group from "test" to "dev" for broader development tooling
- Updated versioning scheme from "only-version" to "no-guess-dev" for better development version handling
- Enhanced tag regex pattern to support more flexible version formats including pre-release versions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updated versioning configuration and renamed test dependencies to dev dependencies |
| .github/workflows/ci.yml | Modified CI to use dev dependencies and added full git history fetch for versioning |
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # full history | ||
| fetch-tags: true # redundant in v4, but explicit |
There was a problem hiding this comment.
[nitpick] The comment indicates this option is redundant in actions/checkout@v4. Consider removing the redundant option to keep the configuration clean, or update the comment to explain why explicit specification is preferred despite being redundant.
Suggested change
| fetch-tags: true # redundant in v4, but explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.