Skip to content

versioning stuff #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amniskin merged 5 commits into from
Jul 29, 2025
Merged

versioning stuff #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de8e5ed
wip
amniskin Jul 29, 2025
152122b
wip
amniskin Jul 29, 2025
d7909dc
wip
amniskin Jul 29, 2025
9b078d5
wip
amniskin Jul 29, 2025
0ac8607
wip
amniskin Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- "**"
tags:
- "v[0-9]+.[0-9]+.[0-9]+" # Semantic version tags
- "v*" # Semantic version tags
pull_request:
jobs:
test:
Expand All @@ -15,6 +15,8 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # full history
fetch-tags: true # redundant in v4, but explicit
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment indicates this option is redundant in actions/checkout@v4. Consider removing the redundant option to keep the configuration clean, or update the comment to explain why explicit specification is preferred despite being redundant.

Suggested change
fetch-tags: true # redundant in v4, but explicit

Copilot uses AI. Check for mistakes.
submodules: "recursive"
- name: Set up Python
uses: actions/setup-python@v5
Expand All @@ -24,7 +26,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install submodules/daggerml_cli/
pip install .[test]
pip install .[dev]
- name: pytest
run: python -m pytest -m "not slow" .
lint:
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = []

[project.optional-dependencies]
cli = ["daggerml-cli>=0.0.33"]
test = [
dev = [
"pytest",
"pytest-cov",
"moto[all,server]",
Expand Down Expand Up @@ -60,9 +60,9 @@ markers = [
source = "vcs"

[tool.hatch.version.raw-options]
version_scheme = "only-version" # use tag as version
version_scheme = "no-guess-dev" # use tag as version if exists
local_scheme = "no-local-version" # pypi does not support local-schemes
tag_regex = "^v(?P<version>[0-9.]+)$"
tag_regex = "^v(?P<version>[0-9]+\\.[0-9]+\\.[0-9]+(?:[-\\.][a-zA-Z0-9]+)*)$"
version_file = "src/daggerml/__about__.py" # write version info to this file
relative_to = "{root:uri}"

Expand All @@ -74,7 +74,7 @@ artifacts = [

[tool.hatch.envs.default]
python="3.10"
features = ["test"]
features = ["dev"]
dependencies = ["twine"]
pre-install-commands = [
"pip install -e {root:uri}/submodules/daggerml_cli",
Expand Down