Update refs to release-1.2-rc1#547
Merged
Merged
Conversation
halspang
force-pushed
the
release-1.2
branch
2 times, most recently
from
fd47f8f to
61fc7fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
============================================
- Coverage 80.65% 80.52% -0.14%
+ Complexity 982 981 -1
============================================
Files 88 88
Lines 3024 3024
Branches 331 331
============================================
- Hits 2439 2435 -4
- Misses 420 423 +3
- Partials 165 166 +1
Continue to review full report at Codecov.
|
| --> | ||
|
|
||
| ```bash | ||
| dapr stop --app-id exception_example |
Contributor
There was a problem hiding this comment.
Is this removed due to the related change in CLI to exit with error when app id is not found?
dapr/cli@7b69e1a
@halspang
cc @artursouza
Contributor
Author
There was a problem hiding this comment.
Yes. With that change, a lot of the examples will finish and close everything successfully. When we attempted to close it we'd get error messages, hence the removal.
artursouza
approved these changes
May 19, 2021
artursouza
added a commit
that referenced
this pull request
May 19, 2021
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update refs to release-1.2-rc1
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: