Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
DAPR_CLI_VER: 1.1.0-rc.1
DAPR_RUNTIME_VER: 1.1.0-rc.1
DAPR_INSTALL_URL: https://raw.githubusercontent.com/dapr/cli/3dacfb672d55f1436c249057aaebbe597e1066f3/install/install.sh
DAPR_CLI_REF:
DAPR_REF: 266eb0b5d300c576c3360c7f0582d795579ee457
DAPR_CLI_REF: e00080697f348c6123f67e16b22f3c5247d7ac99
DAPR_REF: 57582853ea5db9b6991bdcf07de6f61b165aa960
OSSRH_USER_TOKEN: ${{ secrets.OSSRH_USER_TOKEN }}
OSSRH_PWD_TOKEN: ${{ secrets.OSSRH_PWD_TOKEN }}
GPG_KEY: ${{ secrets.GPG_KEY }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
DAPR_CLI_VER: 1.1.0-rc.1
DAPR_RUNTIME_VER: 1.1.0-rc.1
DAPR_INSTALL_URL: https://raw.githubusercontent.com/dapr/cli/3dacfb672d55f1436c249057aaebbe597e1066f3/install/install.sh
DAPR_CLI_REF:
DAPR_REF:
DAPR_CLI_REF: e00080697f348c6123f67e16b22f3c5247d7ac99
DAPR_REF: 57582853ea5db9b6991bdcf07de6f61b165aa960
steps:
- uses: actions/checkout@v2
- name: Set up OpenJDK ${{ env.JDK_VER }}
Expand Down
14 changes: 0 additions & 14 deletions examples/src/main/java/io/dapr/examples/exception/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,3 @@ Once running, the OutputBindingExample should print the output as follows:
...

```

### Cleanup

To stop the app run (or press `CTRL+C`):

<!-- STEP
name: Cleanup
-->

```bash
dapr stop --app-id exception_example

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removed due to the related change in CLI to exit with error when app id is not found?
dapr/cli@7b69e1a
@halspang
cc @artursouza

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. With that change, a lot of the examples will finish and close everything successfully. When we attempted to close it we'd get error messages, hence the removal.

```

<!-- END_STEP -->
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ name: Cleanup
-->

```bash
dapr stop --app-id publisher
dapr stop --app-id subscriber
```

Expand Down
26 changes: 0 additions & 26 deletions examples/src/main/java/io/dapr/examples/secrets/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,19 +209,6 @@ Once running, the program should print the output as follows:
== APP == {"testVal":"value"}
```

To close the app either press `CTRL+C` or run

<!-- STEP
name: Cleanup first app
-->

```bash
dapr stop --app-id secrets1
```

<!-- END_STEP -->


The example's `config.yaml` is as follows:
```yaml
apiVersion: dapr.io/v1alpha1
Expand Down Expand Up @@ -265,19 +252,6 @@ Once running, the program should print the output as follows:
== APP == PERMISSION_DENIED: access denied by policy to get "randomKey" from "vault"
```

To close the app either press `CTRL+C` or run

<!-- STEP
name: Cleanup second app
-->

```bash
dapr stop --app-id secrets2
```

<!-- END_STEP -->


To clean up and bring the vault container down, run

<!-- STEP
Expand Down
14 changes: 0 additions & 14 deletions examples/src/main/java/io/dapr/examples/state/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -202,17 +202,3 @@ Once running, the OutputBindingExample should print the output as follows:
== APP == Done

```

### Cleanup

To close the app either press `CTRL+C` or run

<!-- STEP
name: Cleanup
-->

```bash
dapr stop --app-id state_example
```

<!-- END_STEP -->
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<grpc.version>1.33.1</grpc.version>
<protobuf.version>3.13.0</protobuf.version>
<dapr.proto.baseurl>https://raw.githubusercontent.com/dapr/dapr/v1.1.0-rc.1/dapr/proto</dapr.proto.baseurl>
<dapr.proto.baseurl>https://raw.githubusercontent.com/dapr/dapr/57582853ea5db9b6991bdcf07de6f61b165aa960/dapr/proto</dapr.proto.baseurl>
<os-maven-plugin.version>1.6.2</os-maven-plugin.version>
<maven-dependency-plugin.version>3.1.1</maven-dependency-plugin.version>
<maven-antrun-plugin.version>1.8</maven-antrun-plugin.version>
Expand Down